snappy build fails on broken symlinks

[Martin Pitt]

snappy build fails on broken symlinks:

$ snappy build app/
WARNING:root:Ignoring missing framework "ubuntu-core-15.04-dev1"
Traceback (most recent call last):
  File "/usr/bin/snappy", line 9, in <module>
    status = Main().__main__()
  File "/usr/lib/python3/dist-packages/snappy/main.py", line 103, in __main__
    return callback(args)
  File "/usr/lib/python3/dist-packages/snappy/main.py", line 128, in _do_build
    path = builder.build(".", manifest_path="meta/package.yaml")
  File "/usr/lib/python3/dist-packages/click/build.py", line 413, in build
    with open(os.path.join(root_path, path), "rb") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/click3m7may7y/data/debs/usr/lib/x86_64-linux-gnu/icu/pkgdata.inc'

$ ls -l app/debs/usr/lib/x86_64-linux-gnu/icu/pkgdata.inc
lrwxrwxrwx 1 martin martin 19 Oct 9 09:37 app/debs/usr/lib/x86_64-linux-gnu/icu/pkgdata.inc -> current/pkgdata.inc

This is a tree from unpacking the ~ 100 Ubuntu package dependencies of that app into the deb/ subdir; due to that some symlinks are broken.

[Alexander Sack (asac)]

given the zen of snapps, maybe symlinks should be resolved and wrapped rather than restored if they refer to anything outside the snapp tree itself?

if so it would be dupe of bug 1400303 i guess (or rather that one could be folded into the build part.

tagging snappy-xp-devel since this is about better magic for snappy build.

[Alexander Sack (asac)]

same as in 303 ... one of thse bugs or both are probably fixed.

[Martin Pitt (pitti)]

No, still not fixed. With current snappy-tools when I disable the workaround it fails on

WARNING:root:Ignoring missing framework "ubuntu-core-15.04-dev1"
Traceback (most recent call last):
  File "/usr/bin/snappy", line 9, in <module>
    status = Main().__main__()
  File "/usr/lib/python3/dist-packages/snappy/main.py", line 103, in __main__
    return callback(args)
  File "/usr/lib/python3/dist-packages/snappy/main.py", line 128, in _do_build
    path = builder.build(".", manifest_path="meta/package.yaml")
  File "/usr/lib/python3/dist-packages/click/build.py", line 413, in build
    with open(os.path.join(root_path, path), "rb") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/clickfkkk9w73/data/debs/etc/modules-load.d/modules.conf'

[John Lenton (chipaca)]

This has been fixed (by moving to the go version of snappy).