move away from using by-partuuid, and instead find partition block device that can be mounted directly

Bug #1902734 reported by Dimitri John Ledkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
snapd
Triaged
Low
Unassigned

Bug Description

move away from using by-partuuid, and instead fine partition block device that can be mounted directly.

For example, instead of using disk.FindMatchingPartitionUUID("ubuntu-save")=UUID and then appending that to /dev/disky/by-partuuid/UUID and then mounting it.

We could add an api disk.FindMatchingPartition("ubuntu-save") which directly returns /dev/nvme0n1p3 which can then be directly passed to doSystemdMount. Doing that will save on string manipulation; can be done entirely with sysfs, without udevd/udevadm calls, and mocked with files.

Some of this is started in https://github.com/snapcore/snapd/pull/9594/files

Changed in snapd:
importance: Undecided → Low
Changed in snapd:
assignee: nobody → Ian Johnson (anonymouse67)
Changed in snapd:
status: New → Triaged
Revision history for this message
Ian Johnson (anonymouse67) wrote :

All of the primitives are there for this in the disks package, just needs to have the functions changed in the call sites in cmd_initramfs_mounts.go

Changed in snapd:
assignee: Ian Johnson (anonymouse67) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.