errtracker unit tests interact with real whoopsie.service

[Zygmunt Krynicki]

Ubuntu 20.04 with disabled whoopsie.service:

zyga@fyke:~/Documents/go/src/github.com/snapcore/snapd/errtracker$ go test

----------------------------------------------------------------------
FAIL: errtracker_test.go:128: ErrtrackerTestSuite.TestReport

errtracker_test.go:215:
    c.Check(id, Equals, "c14388aa-f78d-11e6-8df0-fa163eaf9b83 OOPSID")
... obtained string = ""
... expected string = "c14388aa-f78d-11e6-8df0-fa163eaf9b83 OOPSID"

errtracker_test.go:216:
    c.Check(n, Equals, 1)
... obtained int = 0
... expected int = 1

errtracker_test.go:225:
    c.Check(n, Equals, 1)
... obtained int = 0
... expected int = 1

errtracker_test.go:230:
    c.Check(id, Equals, "xxxxx-f78d-11e6-8df0-fa163eaf9b83 OOPSID")
... obtained string = ""
... expected string = "xxxxx-f78d-11e6-8df0-fa163eaf9b83 OOPSID"

errtracker_test.go:231:
    c.Check(n, Equals, 2)
... obtained int = 0
... expected int = 2

----------------------------------------------------------------------
FAIL: errtracker_test.go:291: ErrtrackerTestSuite.TestReportRepair

errtracker_test.go:353:
    c.Check(id, Equals, "c14388aa-f78d-11e6-8df0-fa163eaf9b83 OOPSID")
... obtained string = ""
... expected string = "c14388aa-f78d-11e6-8df0-fa163eaf9b83 OOPSID"

errtracker_test.go:354:
    c.Check(n, Equals, 1)
... obtained int = 0
... expected int = 1

----------------------------------------------------------------------
FAIL: errtracker_test.go:234: ErrtrackerTestSuite.TestReportUnderTesting

errtracker_test.go:258:
    c.Check(id, Equals, "oops-not-sent")
... obtained string = ""
... expected string = "oops-not-sent"

----------------------------------------------------------------------
FAIL: errtracker_test.go:262: ErrtrackerTestSuite.TestTriesAllKnownMachineIDs

errtracker_test.go:287:
    c.Check(n, Equals, 1)
... obtained int = 0
... expected int = 1

errtracker_test.go:288:
    c.Check(identifiers, DeepEquals, []string{fmt.Sprintf("/%x", sha512.Sum512(machineID))})
... obtained []string = []string(nil)
... expected []string = []string{"/556a93a1bf91e95c421f783590f64a0f81a2be7f5adbe31a003ccedf47eeafd1b46517691382ed576aa9200b8e73d4505b9c464b24e37dea4b6dc2dee53ec685"}
... Difference:
... []string[0] != []string[1]

OOPS: 14 passed, 4 FAILED
--- FAIL: Test (0.15s)
FAIL
exit status 1
FAIL github.com/snapcore/snapd/errtracker 0.157s

We fail to mock systemctl status, is-enabled and perhaps other aspects of whoopsie.

[Michael Vogt (mvo)]

diff --git a/errtracker/errtracker_test.go b/errtracker/errtracker_test.go
index 8bcba72e45..872786220e 100644
--- a/errtracker/errtracker_test.go
+++ b/errtracker/errtracker_test.go
@@ -124,6 +124,9 @@ bugs : very yes
        s.AddCleanup(errtracker.MockProcSelfExe(mockSelfExe))
        s.AddCleanup(errtracker.MockProcSelfCwd(mockSelfCwd))
        s.AddCleanup(testutil.MockCommand(c, "journalctl", "echo "+someJournalEntry).Restore)
+
+ mockCmd := testutil.MockCommand(c, "systemctl", "echo enabled; exit 0")
+ s.AddCleanup(mockCmd.Restore)
 }

 func (s *ErrtrackerTestSuite) TestReport(c *C) {

should fix it

[Paweł Stołowski (stolowski)]

The fix: https://github.com/snapcore/snapd/pull/8347