latest change to xdg-open not applied to the unity7 interface

Bug #1705708 reported by Oliver Grawert on 2017-07-21
44
This bug affects 7 people
Affects Status Importance Assigned to Milestone
snapd
High
Oliver Grawert

Bug Description

when we moved xdg-open inside core from /usr/local/bin to /usr/bin, the path of the unity7 interface was not adjusted for it:

[185082.350751] audit: type=1400 audit(1500643168.604:11132): apparmor="DENIED" operation="exec" profile="snap.snapcraft-forum.snapcraft-forum" name="/usr/bin/xdg-open" pid=29969 comm="sh" requested_mask="x" denied_mask="x" fsuid=1001 ouid=0

ogra@styx:~$ ls /snap/core/current/usr/bin/xdg-open
/snap/core/current/usr/bin/xdg-open

but:

ogra@styx:~/Devel/branches/snapd/interfaces/builtin$ grep bin/xdg-open unity7.go
/usr/local/bin/xdg-open ixr,

Oliver Grawert (ogra) on 2017-07-21
description: updated
Oliver Grawert (ogra) wrote :
Changed in snapd:
assignee: nobody → Oliver Grawert (ogra)
status: New → In Progress
importance: Undecided → High
Zygmunt Krynicki (zyga) wrote :

I think is now fixed in 2.27.2; ogra, can you please confirm and close?

Milorad Pop-Tosic (pop-0) wrote :

Just tried this on a a fresh install of 17.10 with snapd 2.27.2 and I'm seeing a weird issue.

$ snap run --shell hiri
To run a command as administrator (user "root"), use "sudo <command>".
See "man sudo_root" for details.

osboxes@osboxes:/home/osboxes$ xdg-open https://www.google.com
Error org.freedesktop.DBus.Error.ServiceUnknown: The name com.canonical.SafeLauncher was not provided by any .service files

The links work if I install snapd-xdg-open, but I understand that this package isn't required anymore?

Oddly, when I then uninstall snapd-xdg-open, the links continue to work. As if something got left behind.

Oliver Grawert (ogra) wrote :

snapd-xdg-open is still required until https://github.com/snapcore/snapd/pull/3260 is implemented ...

Oliver Grawert (ogra) wrote :

@zyga:

ogra@styx:~$ snap info core|grep stable
  stable: 16-2.26.14 (2462) 84MB -

not in stable yet ... i will close it once 2.27.2 hits it ...

Milorad Pop-Tosic (pop-0) wrote :

Ok, didn't realise that didn't go in yet. Sorry for the noise.

Zygmunt Krynicki (zyga) wrote :

Technically the upstream snapd source tarball was released already so depending on which OS you are on, you will see things just work.

Ads20000 (ads20000) wrote :

2.27.5 is now in `stable` so closing this bug! :D

Changed in snapd:
status: In Progress → Fix Released
Ads20000 (ads20000) wrote :

Also worth noting that the `snapd-xdg-open` package will no longer be needed when 2.28 is released! :D https://github.com/snapcore/snapd/pull/3260#issuecomment-325560019

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers