git package missing from build VM images

Bug #1802899 reported by Evan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Status tracked in Trunk
Legacy
Fix Committed
High
Sergio Schvezov
Trunk
Fix Released
High
Sergio Schvezov

Bug Description

https://sentry.io/canonical-ao/snapcraft/issues/757489565

Running `snapcraft --debug` and `apt install git` fixes the issue.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

git is autoinstalled by snapcraft if operating on git sources (with source: . then source-type: git might be needed but only if you are going to run git commands).

This is debatable as git is not necessarily going to be preinstalled on the builders and installed as a side effect of the source type. What this needs however is a proper error response.

Revision history for this message
Kyle Fazzari (kyrofa) wrote :

The error here is because `version: git` is being used, and snapcraft doesn't add git to build-packages unless a git source is used. Snapcraft should probably add git to build-packages if `version: git` is used.

Revision history for this message
Evan (ev) wrote :

Thanks Kyle and Sergio.

Confirmed that adding `source-type: git` to a part convinces snapcraft to pull in git. I'm +1 on doing this automatically when `version: git` is set.

Changed in snapcraft:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Sergio Schvezov (sergiusens)
milestone: none → 3.0.1
Revision history for this message
Sergio Schvezov (sergiusens) wrote :
Changed in snapcraft:
status: Triaged → In Progress
tags: added: 18.10-build-vm
Changed in snapcraft:
status: In Progress → Fix Committed
Revision history for this message
Sergio Schvezov (sergiusens) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.