| 2019-07-30 21:45:15 |
Rob Cresswell |
description |
The nodejs plugin currently assumes a version key is present in the package.json[1]; crashing out with a KeyError if it isn't, and doesn't enable any other way of providing a package version, nor does it appear to inherit or otherwise use the 'version' key in the snapcraft.yaml.
What's the best way to fix this? I've really lost my patience trying to wrestling with the tooling and broken links in the documentation, so I'd like to raise a PR to address this ASAP so I can move on.
1. https://github.com/snapcore/snapcraft/blob/master/snapcraft/plugins/nodejs.py#L211 |
The nodejs plugin currently assumes a version key is present in the package.json[1]; crashing out with a KeyError if it isn't, and doesn't enable any other way of providing a package version, nor does it appear to inherit or otherwise use the 'version' key in the snapcraft.yaml.
What's the best way to fix this? I've really lost my patience trying to wrestle with the tooling and broken links in the documentation, so I'd like to raise a PR to address this ASAP so I can move on.
1. https://github.com/snapcore/snapcraft/blob/master/snapcraft/plugins/nodejs.py#L211 |
|
