Push output needs love

Bug #1804439 reported by Gustavo Niemeyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Fix Released
Medium
Claudio Matsuoka

Bug Description

Actual output just now:

1 | Pushing blender_2.80-f021536babb_amd64.snap
2 | After pushing, an attempt will be made to release to 'edge'
3 | Preparing to push '/home/niemeyer/src/snaps/blender/snaps/google:ubuntu-16.04-64:tasks/build:edge/blender_2.80-f021536babb_amd64.snap' to the store.
4 | Found cached source snap /home/niemeyer/.cache/snapcraft/projects/blender/snap_hashes/amd64/d7ad5854c6fb52acf45ede52159cd6a35775451739644f20a14c1ae087f423b6c1bc4beac4b7524667310b9115bead61.
5 | Generating xdelta3 delta for blender_2.80-f021536babb_amd64.snap.
6 | Pushing delta /home/niemeyer/src/snaps/blender/snaps/google:ubuntu-16.04-64:tasks/build:edge/blender_2.80-f021536babb_amd64.snap.xdelta3.
7 | Pushing blender_2.80-f021536babb_amd64.snap.xdelta3 [===============================================================================================================] 100%

Some comments (labeled to make discussion easier):

A. Lines are colored or not, with no clear reason (lines 1, 2, 7 are gray, rest is green). Everything there may be just standard gray.
B. Lines are very long due to the paths, which are uninteresting. I'd suggest presenting just the filenames.
C. Line 4 talks about a "source snap". Source code? Source for the delta? Unclear.. I suggest dropping that line altogether. The fact a delta is generated later means a delta source was found.
D. Some paths are quoted, others are not. Consistency says either all, or none.
E. Lines 6 and 7 say the same thing. Line 6 may be dropped.

Changed in snapcraft:
importance: Undecided → Medium
status: New → Triaged
Changed in snapcraft:
milestone: none → 3.1
assignee: nobody → Sergio Schvezov (sergiusens)
Changed in snapcraft:
milestone: 3.1 → 3.1.1
Changed in snapcraft:
assignee: Sergio Schvezov (sergiusens) → Claudio Matsuoka (cmatsuoka)
Revision history for this message
Claudio Matsuoka (cmatsuoka) wrote :

Also note that in a plain, first time push, line "Pushing <package name>" appears twice:

$ snapcraft push xv_3.10a+20081216-cm1_amd64.snap
Pushing xv_3.10a+20081216-cm1_amd64.snap
Preparing to push '/home/claudio/mysnaps/xv/xv_3.10a+20081216-cm1_amd64.snap' to the store.
Pushing xv_3.10a+20081216-cm1_amd64.snap [=================================================] 100%
Processing...|
Ready to release!

Changed in snapcraft:
status: Triaged → Confirmed
Changed in snapcraft:
status: Confirmed → In Progress
Changed in snapcraft:
milestone: 3.1.1 → 3.2
Revision history for this message
Claudio Matsuoka (cmatsuoka) wrote :

Excessive information moved to debug level and filename representation made consistent across different messages, resulting in an overall cleaner output. Some colorization still remains and is in line with the rest of the application -- log colors and output colorization can be discussed (and eventually fixed) globally.

$ snapcraft push xmdp_0+git.7a7cf60_amd64.snap --release edge
Pushing xmdp_0+git.7a7cf60_amd64.snap.
After pushing, an attempt will be made to release to 'edge'
Generating xdelta3 delta for xmdp_0+git.7a7cf60_amd64.snap.
Pushing xmdp_0+git.7a7cf60_amd64.snap.xdelta3 [=========== // ===========] 100%
Processing...|
Ready to release!
Revision 17 of 'xmdp' created.
Track Arch Channel Version Revision
latest amd64 stable - -
                 candidate - -
                 beta - -
                 edge 0+git.7a7cf60 17

Revision history for this message
Claudio Matsuoka (cmatsuoka) wrote :
Changed in snapcraft:
status: In Progress → Fix Committed
Changed in snapcraft:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.