node app builds forked, but not referencing upstream source

Bug #1731003 reported by Alan Pope 🍺🐧🐱 πŸ¦„ on 2017-11-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Undecided
Unassigned

Bug Description

nba-go seems to build okay when forked, but not when you have a source line pointing to an external URL.

git clone https://github.com/elopio/nba-go.git
cd nba-go
git checkout snapcraft
snapcraft cleanbuild

^ this works

Now copy that url out to an empty dir and change the source line to be
source: https://github.com/xxhomey19/nba-go.git

Then "snapcraft cleanbuild". It fails to build.

I'm using snapcraft, version 2.34 from candidate.

yarn run v1.3.2
$ npm run clean && babel src -d lib --copy-files --ignore '**/*.spec.js' -s

> nba-go@0.1.9 clean /root/build_nba-go/parts/nba-go/src
> rimraf lib

sh: 1: rimraf: not found

npm ERR! Linux 4.10.0-38-generic
npm ERR! argv "/root/build_nba-go/parts/nba-go/install/bin/node" "/root/build_nba-go/parts/nba-go/install/bin/npm" "run" "clean"
npm ERR! node v6.10.2
npm ERR! npm v3.10.10
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! nba-go@0.1.9 clean: `rimraf lib`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the nba-go@0.1.9 clean script 'rimraf lib'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nba-go package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! rimraf lib
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs nba-go
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls nba-go
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! Please include the following file with any support request:
npm ERR! /root/build_nba-go/parts/nba-go/src/npm-debug.log
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Leo Arias (elopio) wrote :

I confirm that it fails when using the external source.
rimraf is a devDependency, which makes me think if there's a problem installing those. But this needs debugging to actually find where the behaviour diverges.

Changed in snapcraft:
status: New → Confirmed
tags: added: plugin
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers