“snapcraft register” with invalid characters still blathers on about name ownership

[Matthew Paul Thomas]

0. Sign in with “snapcraft login” if you aren’t signed in already.
1. At the command line, enter “snapcraft register Firefox”.
2. Enter “y”.

What happens:
------------
 😌 11:15:27@~> snapcraft register Firefox

We always want to ensure that users get the software they expect
for a particular name.

If needed, we will rename snaps to ensure that a particular name
reflects the software most widely expected by our community.

For example, most people would expect ‘thunderbird’ to be published by
Mozilla. They would also expect to be able to get other snaps of
Thunderbird as 'thunderbird-$username'.

Would you say that MOST users will expect 'Firefox' to come from
you, and be the software you intend to publish there? [y/N]: y
Registering Firefox.
The name 'Firefox' is not valid. It can only contain dashes, numbers and lowercase ascii letters.
------------

What should happen: If the name is not valid, only the error message should appear. The babble and question about people expecting the name should not appear.

[Originally mentioned by Kyle Fazzari in bug 1644673.]

[Matthew Paul Thomas (mpt)]

For further evidence that this question is being asked at the wrong time, consider the case where you try to register a name that is already taken:

------------
If needed, we will rename snaps to ensure that a particular name
reflects the software most widely expected by our community.

For example, most people would expect ‘thunderbird’ to be published by
Mozilla. They would also expect to be able to get other snaps of
Thunderbird as 'thunderbird-$username'.

Would you say that MOST users will expect 'firefox' to come from
you, and be the software you intend to publish there? [y/N]: y
Registering firefox.
The name 'firefox' is already taken.

We can if needed rename snaps to ensure they match the expectations of most users. If you are the publisher most users expect for 'firefox' then claim the name at 'https://dashboard.snapcraft.io/dev/snaps/register-name/?series=16&name=firefox'
------------

Snapcraft ends up paraphrasing itself — “If needed, we will rename snaps to ensure that a particular name reflects the software most widely expected by our community … We can if needed rename snaps to ensure they match the expectations of most users” — because it was asking the question before it knew in what context to ask it.