snapcraft turns the console text green

Bug #1692754 reported by Leo Arias
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Snapcraft
Fix Released
High
Kyle Fazzari

Bug Description

When a successful snapcraft execution finishes, it prints a green success message. The problem is the green color remains stuck for all the following text in the terminal (see the attached screenshot).

Instead, the next prompt after the successful message should return to the normal terminal color.

To reproduce:

Install snapcraft 2.30
$ snapcraft init
$ snapcraft

Tags: ui
Revision history for this message
Leo Arias (elopio) wrote :
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

I am not seeing this.

Revision history for this message
Leo Arias (elopio) wrote :

Where are you testing sergiusens? Happens on all my lxcs.

Revision history for this message
Leo Arias (elopio) wrote :

Actually, this only happens on the LXCs in my canonistack dev machine. I can't reproduce this locallay, or in a vm. :/

Revision history for this message
Seth Arnold (seth-arnold) wrote :

What terminal are you using? What's the TERM environment variable set to? Is there a corresponding /usr/share/terminfo/ file for your terminal in whatever filesystem namespace the terminal's shell is running in?

Thanks

Revision history for this message
Gustavo Silva (gsilvapt) wrote :

Wanted to reproduce this bug (Ubuntu Gnome 16.04) but faced some issues building from the source.

To build version 2.30 (I can't use apt for this, right?), I cloned the Git's repository, changed to branch 2.30 (git checkout 2.30) and simply tried sudo dpkg-buildpackage -us -uc -d. I previously had used apt-get source snapcraft and then tried building from there but not success. I also had built all dependencies using apt build-dep snapcraft.

The buildpackage command has a massive output but in the end it returned:
FAILED (errors=1)
E: pybuild pybuild:274: test: plugin distutils failed with: exit code=1: python3.5 setup.py test
dh_auto_test: pybuild --test -i python{version} -p 3.5 --dir . returned exit code 13
debian/rules:5: recipe for target 'build' failed
make: *** [build] Error 22
dpkg-buildpackage: error: debian/rules build gave error exit status 2

This seems to be related with the rules file but I can't find any extra whitespace in there. What am I doing wrong?
Thanks!

Revision history for this message
Gustavo Silva (gsilvapt) wrote :

Tried reproducing the bug with version 2.29 and the console text turned green:
http://imgur.com/a/xSM3o

I?m using Gnome terminal 3.18.3, Ubuntu Gnome 16.04, no TERM set (only in vim). However, I'm not sure if these are set somewhere else, so please let me know if this could be defined in another file.

Hope this helps.

Leo Arias (elopio)
tags: removed: bitesize
Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Happened to me too, running a Trusty lxc on a Xenial host, accessed via `lxc exec <container> bash`.

Leo Arias (elopio)
Changed in snapcraft:
status: Triaged → Confirmed
Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Please try the fix proposed here: https://github.com/snapcore/snapcraft/pull/1360

Kyle Fazzari (kyrofa)
Changed in snapcraft:
status: Confirmed → Fix Committed
assignee: nobody → Kyle Fazzari (kyrofa)
Kyle Fazzari (kyrofa)
Changed in snapcraft:
milestone: none → 2.32
Kyle Fazzari (kyrofa)
Changed in snapcraft:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.