Snapcraft travis runs with "tests triggered by OLS" are failing

[Daniel Manrique]

https://travis-ci.org/snapcore/snapcraft/jobs/210968966

Reading state information... Done

2 packages can be upgraded. Run 'apt list --upgradable' to see them.

sh: 1: sudo: not found

The command "docker run -e TEST_USER_PASSWORD=$TEST_USER_PASSWORD -e TEST_STORE=$TEST_STORE -e TEST_USER_EMAIL=$TEST_USER_EMAIL -v $(pwd):$(pwd) -t ubuntu:xenial sh -c "export LC_ALL=en_US.UTF-8 && locale-gen en_US.UTF-8 && apt update && cd $(pwd) && $DEPENDENCIES && ./runtests.sh $TEST_SUITE"" exited with 127.

Further up I see DEPENDENCIES defined as such, and I think this is the offending sudo invocation:

Setting environment variables from .travis.yml

$ export TEST_USER_PASSWORD=[secure]

$ export CHECK_CLA=1

$ export DEPENDENCIES="sudo apt install -y python-launchpadlib"

This comes from .travis.yml line 21 which specifies "sudo apt install" where I think it should be sudoless.

[Leo Arias (elopio)]

Thanks for the report Daniel. Can you point me to your script that triggers this?
It shouldn't run the CHECK_CLA at all.

[Daniel Manrique (roadmr)]

Here it is, I obfuscated anything looking like credentials or e-mail addresses but otherwise it's exactly what I used:

https://pastebin.canonical.com/182463/

[Leo Arias (elopio)]

Thanks Daniel.
I'm not sure how to remove the CLA from the matrix. I added it that way to save a few minutes by not launching the docker container, but I think it will have to get it back.

[Leo Arias (elopio)]

https://github.com/snapcore/snapcraft/pull/1191

[Daniel Manrique (roadmr)]

Thanks!

Does my script need any changes?

[Leo Arias (elopio)]

I think that by pure luck, it doesn't.
Why don't you push it to our tools directory, so we can update it in sync with .travis.yml?
You'll just have to add to arguments for user and password, I think.