It is possible to make a snap with an empty version

[Leo Arias]

The version of the snaps is free form, but we should at least verify that it is a non-empty string.

Currently it is possible to write a snap with

"version: "

or

"version: ''"

and snapcraft won't complain.

In this cases, an error message should be returned.

To reproduce:

$ snapcraft init
$ sed -i "s/version:.*$/version: ''/g" snapcraft.yaml
$ snapcraft
[...]
Snapped my-snap-name__amd64.snap <- Note the missing version.

$ sed -i "s/version:.*$/version: /g" snapcraft.yaml
$ snapcraft
[...]
Snapped my-snap-name_None_amd64.snap <- Note "None" instead of the version.

[Leo Arias (elopio)]

Note that this will build successfully, but it will fail when pushed to the store.

[Kyle Fazzari (kyrofa)]

Does it install, though?

[Leo Arias (elopio)]

Yes, it can be installed.

[Kyle Fazzari (kyrofa)]

Perhaps this should apply to snapd as well, then?

[Leo Arias (elopio)]

I'm not sure, but I've marked it as affecting them to discuss it.

As they don't use the version for anything, maybe it's valid to have a local snap with an empty version. I don't see why, but maybe.

[Kyle Fazzari (kyrofa)]

In my mind, if it's valid, then all tools (snapcraft and the review tools) should accept it. If it's invalid, none of them should. Thoughts?

[Kyle Fazzari (kyrofa)]

Adding the review tools as well to broaden the discussion to all affected parties.

[Sergio Schvezov (sergiusens)]

sergiusens@mirkwood:~/t$ snapcraft
Issues while validating snapcraft.yaml: The 'version' property does not match the required schema: '' does not match '^[a-zA-Z0-9.+~-]+$'
sergiusens@mirkwood:~/t$ grep version snap/snapcraft.yaml
version: '' # just for humans, typically '1.2+git' or '1.3.2'
sergiusens@mirkwood:~/t$ snapcraft --version
snapcraft, version 2.33

[Zygmunt Krynicki (zyga)]

I'm closing the snapd part of this bug as it is possible to hand-craft a snap with an empty version AFAIK

[Jamie Strandboge (jdstrand)]

Closing the review tools task since it has always required the version field be non-empty:

Errors
------
 - lint-snap-v2:version_valid
 malformed 'version': ''