Collision detection doesn't compare symlinks to files or directories

Bug #1658225 reported by Kyle Fazzari
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Kyle Fazzari

Bug Description

Snapcraft runs a collision detection algorithm when attempting to merge two parts. This algorithm has two related issues:

1. It only compares files, which means files (e.g. symlinks) that collide with directories are missed until the migration is attempted, at which point cryptic "destination is a directory" errors are raised.
2. If a file in both parts is a symlink, it immediately assumes they don't collide, without checking where they're pointing. If they point to different places they _should_ collide.

Kyle Fazzari (kyrofa)
Changed in snapcraft:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Kyle Fazzari (kyrofa)
description: updated
Revision history for this message
Kyle Fazzari (kyrofa) wrote :
Revision history for this message
Leo Arias (elopio) wrote :

Back to triaged because the PR never landed.

Changed in snapcraft:
status: In Progress → Triaged
Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Re-proposed same PR.

Changed in snapcraft:
status: Triaged → In Progress
milestone: none → 2.43
Changed in snapcraft:
status: In Progress → Fix Committed
Changed in snapcraft:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.