the desktop attribute from snapcraft.yaml ends up in snap.yaml

[Leo Arias]

I made a snapcraft.yaml with a desktop attribute in an app. After creating the snap, this attribute is copied to snap.yaml:

$ cat /snap/keepassxc/current/meta/snap.yaml
apps:
  keepassxc:
    command: command-keepassxc.wrapper
    desktop: share/applications/keepassxc.desktop <--- ****BUG****
    plugs:
    - unity7
    - opengl
    - gsettings
    - home
architectures:
- amd64
confinement: strict
description: |
  KeePassXC is an application for people with extremly high demands on secure
  personal data management. It has a light interface, is cross platform and
  published under the terms of the GNU General Public License.
grade: stable
name: keepassxc
summary: "community driven port of the windows application \u201CKeepass Password\
  \ Safe\u201D"
version: develop

That is wrong because the snap.yaml specification doesn't include a desktop attribute. It should be stripped during the creation of the snap.

[Leo Arias (elopio)]

Setting priority to low because it doesn't seem to affect the snap at all, it's just ignored.

[Sergio Schvezov (sergiusens)]

https://github.com/snapcore/snapcraft/pull/1053

[Olivier Tilloy (osomon)]

Thanks for spotting the issue Leo, and thanks Sergio for fixing it!
It doesn’t affect the snap itself (the key is ignored indeed), however the store review tools raise a warning that prevents publication:

unknown fields for app 'webbrowser-app': 'desktop' lint-snap-v2_apps_unknown (webbrowser-app)

[Sergio Schvezov (sergiusens)]

On Thu, 19 Jan 2017 13:40:36 +0000, Olivier Tilloy wrote:
> Thanks for spotting the issue Leo, and thanks Sergio for fixing it!
> It doesn’t affect the snap itself (the key is ignored indeed),
> however the store review tools raise a warning that prevents
> publication:
>
> unknown fields for app 'webbrowser-app': 'desktop' lint-snap-
> v2_apps_unknown (webbrowser-app)

Can you try building with master and check if everything is still good just in case?

--
Sent using Dekko from my Ubuntu device

[Olivier Tilloy (osomon)]

Confirmed: I built the webbrowser-app snap with snapcraft master, and the resulting snap doesn't have the desktop key in meta/snap.yaml, but the desktop file is correctly copied to meta/gui/.

[Leo Arias (elopio)]

Thanks for the info about the reviewer tools, osomon. I've raised the priority accordingly.

[Jamie Strandboge (jdstrand)]

Ideally we'd do a quick release of 2.26 of 2.25.1 for this fix. When is the release planned?

[Leo Arias (elopio)]

Jamie, we are finishing the last details for the release. It will go out early next week.
Do you think we should make a release only with this fix?

Personally, I think it's not that critical because the workaround is to just keep using the previous way to define a desktop file for one more week, but your opinion will be appreciated.