Additional "invalid credential" message displayed

Bug #1650938 reported by Leo Arias on 2016-12-18
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Snapcraft
Medium
Unassigned

Bug Description

When I try to run a store command without having run snapcraft login first, now the message printed is this:

$ snapcraft list-keys
No valid credentials found. Have you run "snapcraft login"?
Invalid credentials: Root macaroon not in the config file.

The second message is useless, and talks about a macaroon that's a detail a user shouldn't need to know.

Leo Arias (elopio) wrote :

Setting priority to medium because many users are likely to see this message.

Changed in snapcraft:
status: New → Triaged
Seth Arnold (seth-arnold) wrote :

I suggest to keep the specific error message -- I really dislike trying to troubleshoot problems with vague error messages from programs. Concrete specific problems can be addressed and fixed, "there was an error" messages cannot. (Ask yourself how many times you've had to resort to strace to find the cause of a problem that could have been avoided with a simple perror("syscall"); in the code.. same thing here.)

It may make sense to swap the lines, just so that the line closest to the next shell prompt has the advice for 'new users'.

Thanks

RoxD (roxd) wrote :

Good point Seth. I can make this change if this is agreed as the right approach.

RoxD (roxd) wrote :

Also I realize I'm looking at old bugs, sorry if this was already addressed somehow.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers