the go plugin doesn't use go build-snaps

[Leo Arias]

We are currently using the golang-go package from the xenial or yakkety, which is currently 1.6.

Go 1.7 was released some days ago, and there are already projects using it that won't be able to be snapped.

Update: we added build-snaps to snapcraft, and now there is a go snap with the latest versions. The go plugin should be able to use the go build-snap instead of the go deb.

[deadprogram (ron-s)]

This is a big problem for many Golang projects that use features only available in golang 1.7+ such as 'Context' as they cannot be built under earlier versions.

[Leo Arias (elopio)]

Workaround using a custom plugin and the ppa: https://github.com/elopio/hashicorp-snaps/blob/master/vault/parts/plugins/x-go.py

[Leo Arias (elopio)]

This is now also needed by the ipfs snap: https://github.com/elopio/ipfs-snap
And consequently, by the openbazaar snap: https://github.com/OpenBazaar/openbazaar-go/blob/master/snapcraft.yaml

[Alan Pope 🍺🐧🐱 🦄 (popey)]

This is also needed by the teleconsole snap.

[Leo Arias (elopio)]

sabdfl: @elopio i started a golang snap since it would be best to shift the ubuntu developer community to that rather than a PPA
elopio: @sabdfl yes 🙂 the solution we are thinking about is to just use something that provides go. And if you get that, the plugin will not install it from the archive. Ideally, I think it should be flexible enough to let you use a binary curled, or a snap, or a ppa, or whatever method you have to get the binary into the build machine.
sabdfl: @elopio i think we can be much more opinionated than that
sabdfl: we want to steer people to reinforce the quality of snaps
sabdfl: i think golang is a great example of a classic snap
sabdfl: compilers in general will suit snaps very nicely

[Michael Hudson-Doyle (mwhudson)]

On 3 February 2017 at 03:47, Leo Arias <email address hidden> wrote:

> sabdfl: @elopio i started a golang snap since it would be best to shift
> the ubuntu developer community to that rather than a PPA
>

I have one of them too (
https://code.launchpad.net/~mwhudson/+git/gosnap/+ref/master), I've been
slack about getting people to try it out. I'll post to snapcraft@ now...

[Mark Shuttleworth (sabdfl)]

Can this be done using the new go snap tracks?

Mark

[Sergio Schvezov (sergiusens)]

On Fri, 17 Feb 2017 12:22:03 +0000, Mark Shuttleworth wrote:
> Can this be done using the new go snap tracks?

Yes I was waiting for this to be released, but I also need to discuss with Colin or William on how using snaps as build-packages replacements would affect launchpad builders.

--

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Given we have a go snap now, this bug is probably invalid.

[Leo Arias (elopio)]

Not really, because we have to update the plugin to not install the deb if the snap is installed. Or something along that way.

Currently, the deb is always installed. And if there is no go binary in the stage dir, the go binary in $PATH will be used.

[Sergio Schvezov (sergiusens)]

On mar, oct 31, 2017 at 1:58 AM, Leo Arias <email address hidden>
wrote:
> Not really, because we have to update the plugin to not install the
> deb
> if the snap is installed. Or something along that way.
>
> Currently, the deb is always installed. And if there is no go binary
> in
> the stage dir, the go binary in $PATH will be used.

If this is your triaging, then you need to update the title as this is
not what this bug is about.

[Nicholas Skaggs (nskaggs)]

Just adding juju snap would also appreciate this -- we want to consume go from a specific go track and use it for building with godeps plugin.

[Nicholas Skaggs (nskaggs)]

Also worth noting my efforts to use lp builders to override PATH for the deb installed go or install the go snap in a build/prepare scriptlet didn't work.

error: cannot perform the following tasks:
- Make snap "core" (3444) available to the system (cannot cleanup failed attempt at making snap "core" available to the system: cannot remove snap current symlink: remove /snap/core/current: directory not empty)
- Make snap "core" (3444) available to the system (symlink 3444 /snap/core/current: file exists)

[Sergio Schvezov (sergiusens)]

https://github.com/snapcore/snapcraft/pull/2194