No claim url return in a 409 error payload

Bug #1598905 reported by Sergio Schvezov on 2016-07-04
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Snapcraft
Medium
Joe Talbott
Software Center Agent
Undecided
Fabián Ezequiel Gallina

Bug Description

When trying to register a reserved or already registered snap there is no information provided about where to make a claim on such a name.

e.g.; https://myapps.developer.ubuntu.com/dev/click-apps/register-name-dispute/?series=16&name=firefox

Changed in software-center-agent:
assignee: nobody → Fabián Ezequiel Gallina (fgallina)
Changed in snapcraft:
status: New → Triaged
importance: Undecided → Medium

Hi Sergio,

The `register_name_url` key must be present in the payload and should be what you are looking for. Our acceptance tests for the register name API[0] are currently ensuring such key is returned for both reserved names and registered names errors.

Can you confirm this is missing? If so, could you provide more details about the request itself?

[0] http://bazaar.launchpad.net/~ubuntuone-pqm-team/ols-store-tests/store-acceptance-tests/view/head:/tests/api/snap/test_register_name.py

Thanks!
Fabián

El 06/07/16 a las 15:39, Fabián Ezequiel Gallina escribió:
> Hi Sergio,
>
> The `register_name_url` key must be present in the payload and should be
> what you are looking for. Our acceptance tests for the register name
> API[0] are currently ensuring such key is returned for both reserved
> names and registered names errors.
>
> Can you confirm this is missing? If so, could you provide more details
> about the request itself?

The register_name_url is there, but the spec says we should be addressed
to the claim url.

>
>
> [0] http://bazaar.launchpad.net/~ubuntuone-pqm-team/ols-store-tests
> /store-acceptance-tests/view/head:/tests/api/snap/test_register_name.py
>
>
> Thanks!
> Fabián
>

In the case of a reserved name, the returned URL allows the user to continue with the registration, with a message that promptly explains what's about to happen: http://oi67.tinypic.com/2ngwzuc.jpg

In the case of an already registered name, the returned URL would let the user to register the alternate suggested name, while the message explains that the name is already taken with a link to the dispute name form: http://oi63.tinypic.com/16jhook.jpg

The reason behind this is to keep devs unblocked by giving them choices how to follow up. If what's intended is that the already registered name error returns the dispute claim URL as the `register_name_url` it can be done, just confirm that's the case I'll prepare a fix for it.

El miércoles, 6 de julio de 2016 16h'46:23 ART, Fabián Ezequiel Gallina
<email address hidden> escribió:
> In the case of a reserved name, the returned URL allows the user to
> continue with the registration, with a message that promptly explains
> what's about to happen: http://oi67.tinypic.com/2ngwzuc.jpg
>
> In the case of an already registered name, the returned URL would let
> the user to register the alternate suggested name, while the message
> explains that the name is already taken with a link to the dispute name
> form: http://oi63.tinypic.com/16jhook.jpg
>
> The reason behind this is to keep devs unblocked by giving them choices
> how to follow up. If what's intended is that the already registered name
> error returns the dispute claim URL as the `register_name_url` it can be
> done, just confirm that's the case I'll prepare a fix for it.
>
I know all this, but it is not what is in the spec. I need the claim URL,
not the registration one, that is what is in the spec Natalia authored.

--
Enviado con Dekko desde mi dispositivo Ubuntu

Leo Arias (elopio) wrote :

The idea is not to leave the CLI if we can avoid it. In this case, the user can retry registering a different name again from snapcraft. The browser needs to be open only to fill the claim form.

Changed in software-center-agent:
status: New → Fix Committed
Changed in software-center-agent:
status: Fix Committed → Fix Released
tags: added: store
Changed in snapcraft:
milestone: none → 2.28
assignee: nobody → Joe Talbott (joetalbott)
Changed in snapcraft:
milestone: 2.28 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers