Some download are missing ui hints

[Sergio Schvezov]

A progress bar or spinner would be a welcome improvement for some downloads

[Sergio Schvezov (sergiusens)]

https://github.com/snapcore/snapcraft/pull/615

[Seth Arnold (seth-arnold)]

+ with open(destination, 'wb') as destination_file:
+ for buf in request_stream.iter_content(1024):
+ destination_file.write(buf)

I think with today's AF drives and SSDs this may incur write amplification; AF sectors are 4KB, SSD page sizes often are 8KB but can be larger.

I suggest working with larger blocks than 1024 bytes. 8192 would be a better choice. Most drives are happiest writing blocks of 128KB at a time. Hopefully the OS can coalesce these small writes into fewer writes to the underlying block devices but if we submit IO in large pieces in the first place, the OS won't have to coalesce writes.

Thanks

[Leo Arias (elopio)]

Thanks for the comment Seth. Can you please open a new bug for that?

[Seth Arnold (seth-arnold)]

Done, 1612465. Thanks Leo.