get_unbound_discharge returns a tuple with (value, error)

[Leo Arias]

In snapcraft/storeapi/__init__.py, the method get_unbound_discharge returns a tuple. The first element is the return value on success, the second is the error on failure.

That's not pythonic. The method should return the value or raise an exception.

[Impact]

 * For users, none.

 * For developers, the code is less clear because it's not following the common python practices.

[Test Case]

 * Run all the methods that access the store:
   login, upload, download.

[Regression Potential]

 * This could affect the commands that access the store.

[Leo Arias (elopio)]

Also get_macaroon in the same file returns a tuple.

[Leo Arias (elopio)]

https://github.com/ubuntu-core/snapcraft/pull/585

[Steve Langasek (vorlon)]

Hello Leo, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Leo Arias (elopio)]

Tested in an up-to-date xenial:

- enabled -proposed
- update snapcraft-parser to 2.12
- ran exploratory on login, logout, upload, register.

I'm going to mark this as verified, thanks Steve!

[Chris J Arges (arges)]

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.