snapcraft has a copy of pymacaroons code

Bug #1590813 reported by Leo Arias on 2016-06-09
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Medium
Sergio Schvezov
snapcraft (Ubuntu)
Undecided
Unassigned
Xenial
Medium
Unassigned
Yakkety
Medium
Unassigned

Bug Description

pymacaroons has just been released to xenial (thanks to cjwatson). So now we can import it and remove our copy.

[Impact]

 * For users, none, the change should be transparent.

 * For developers, less duplication and less complex code to maintain.

[Test Case]

 * N/A. The duplicated file was removed, peer reviewed and all the tests kept passing.

[Regression Potential]

 * commands that use macaroons authentication could start failing. But we are covered, the integration suite tests all the commands against the staging server.

Leo Arias (elopio) on 2016-06-09
Changed in snapcraft:
status: New → Triaged
importance: Undecided → Medium
Changed in snapcraft:
milestone: none → 2.12
assignee: nobody → Sergio Schvezov (sergiusens)
Sergio Schvezov (sergiusens) wrote :
Changed in snapcraft:
status: Triaged → In Progress
Changed in snapcraft:
status: In Progress → Fix Committed
Leo Arias (elopio) on 2016-06-27
description: updated

Hello Leo, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Leo Arias (elopio) wrote :

Tested in an up-to-date xenial:

- enabled -proposed
- update snapcraft to 2.12
The pymacaroons code is no longer in /usr/lib/python3/dist-packages/snapcraft.

I'm going to mark this as verified, thanks Steve!

tags: added: verification-done
removed: verification-needed
Changed in snapcraft:
status: Fix Committed → Fix Released

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

affects: Ubuntu Xenial → snapcraft (Ubuntu Xenial)
Changed in snapcraft (Ubuntu Xenial):
importance: Undecided → Medium
status: New → Fix Released
Changed in snapcraft (Ubuntu Yakkety):
status: New → Fix Released
importance: Undecided → Medium
Changed in snapcraft (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers