Snap type: change from "os" to "core"

[Kyle Fazzari]

Snapd currently has a snap of type "os," but such names are ambiguous when it comes to running on classic where one already _has_ an OS. This type should be renamed to "core."

[Jamie Strandboge (jdstrand)]

I've adjusted the review tools for this ("type: os" is still recognized though while snapd and snapcraft are being updated).

[Mark Shuttleworth (sabdfl)]

Sorry, I think we want to call the TYPE "os" but the SNAP "core". There
will be other OS snaps, like "personal", as we currently understand the
convergence story.

Mark

[Kyle Fazzari (kyrofa)]

> Sorry, I think we want to call the TYPE "os" but the SNAP "core".

Ah, that invalidates this, then. Sorry Jamie, thanks for being so on top of things!

[Jamie Strandboge (jdstrand)]

Uncommitted the changes (they weren't rolled out anywhere yet and only existed in trunk).

[Gustavo Niemeyer (niemeyer)]

We went back and forth on this issue a bit, but I believe the latest agreement is actually that we want snaps of type "core" indeed. There's no reason to keep the inconsistency of naming something "os" internally when everything else refers to those as "core".

We'll need to support snaps with the old "os" type for quite a while as these are out there, but I'd like to deprecate them sooner rather than later, and refer to these as "core" consistently.

Also, we've agreed that "personal" will actually be built on the same "core" snap, as that's going to be much nicer to work with and maintain.

[Oliver Grawert (ogra)]

is this an RTM task ? (this needs changes in build system and auto-builds too)

[Gustavo Niemeyer (niemeyer)]

We are doing a last minute push to get "ubuntu-core" renamed to "core", so that the images going out on RTM have the logic in place for testing, but this is unrelated to the topic here. This specific bug is simply about having the "core" snap with the "core" type, and this transition needs to be done without breaking current snaps out there.

So yes, the build system needs to change to generate "core" snaps with the "core" type, but that's not urgent as snapd cannot refuse to take a "os" type snap any time soon.

[Zygmunt Krynicki (zyga)]

I believe that under the advice from Mark above this bug is fixed. We currently have a "core" snap of type "os".

[Jamie Strandboge (jdstrand)]

Based on Zygmunt's comment, closing the review tools task as there is nothing to be done.