snap step prints too much information about mksquashfs

Bug #1582955 reported by Leo Arias on 2016-05-18
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Wishlist
Sergio Schvezov
snapcraft (Ubuntu)
Undecided
Unassigned
Xenial
Undecided
Unassigned
Yakkety
Undecided
Unassigned

Bug Description

The snapcraft build finishes with something like this:

Snapping kpcli-elopio_3.0_amd64.snap
Parallel mksquashfs: Using 10 processors
Creating 4.0 filesystem on kpcli-elopio_3.0_amd64.snap, block size 131072.
[===================================================================================-] 2983/2983 100%

Exportable Squashfs 4.0 filesystem, xz compressed, data block size 131072
        compressed data, compressed metadata, compressed fragments, no xattrs
        duplicates are removed
Filesystem size 12193.21 Kbytes (11.91 Mbytes)
        23.13% of uncompressed filesystem size (52710.07 Kbytes)
Inode table size 25248 bytes (24.66 Kbytes)
        23.25% of uncompressed inode table size (108609 bytes)
Directory table size 28830 bytes (28.15 Kbytes)
        42.88% of uncompressed directory table size (67241 bytes)
Number of duplicate files found 481
Number of inodes 3347
Number of files 2752
Number of fragments 168
Number of symbolic links 40
Number of device nodes 0
Number of fifo nodes 0
Number of socket nodes 0
Number of directories 555
Number of ids (unique uids + gids) 1
Number of uids 1
        root (0)
Number of gids 1
        root (0)
Snapped kpcli-elopio_3.0_amd64.snap

Everything between the progress bar and the Snapped message seems irrelevant to me.

[Impact]

 * The output of every snapcraft build is too noise and not really understandable.

 * A cleaner output makes the experience better, and helps to find real errors.

[Test Case]

 * Run snapcraft with and without debug to generate a snap.
 * Check that a progress animations is shown.
 * Check that the output is short and to the point without the flag, and that it's the same as before with the flag.

[Regression Potential]

 * This touches the final step of the snap generation and could break it. We are safe against this regression because we have a suite that generates, installs and executes snaps.

Changed in snapcraft:
assignee: nobody → Sergio Schvezov (sergiusens)
importance: Undecided → Wishlist
status: New → Triaged
milestone: none → 2.10
Mark Shuttleworth (sabdfl) wrote :

Agree, let's suppress the squashfs output unless there is an error.

Gustavo Niemeyer (niemeyer) wrote :

I've talked to Kyle about this on the sprint as well.

Ideally we'd suppress only the boilerplate at the end. The progress bar is quite nice as it can take a while.

Is there a way to hide the details and not the bar? If not, then yeah, hiding it all seems better than the over-verbose output shown right now.

Kyle Fazzari (kyrofa) wrote :

> Is there a way to hide the details and not the bar?

Unfortunately no, mksquashfs doesn't seem to support any silencing options at least as far as I can see, so this is really the only option.

Sergio Schvezov (sergiusens) wrote :
Changed in snapcraft:
status: Triaged → In Progress
Changed in snapcraft:
status: In Progress → Fix Committed
Leo Arias (elopio) on 2016-06-02
description: updated
Leo Arias (elopio) on 2016-06-02
summary: - snap step prints too much information abut mksquashfs
+ snap step prints too much information about mksquashfs
Changed in snapcraft (Ubuntu Xenial):
milestone: none → xenial-updates
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapcraft - 2.10+16.10

---------------
snapcraft (2.10+16.10) yakkety; urgency=medium

  [ Martin Wimpress ]
  * Correct autotools tests to use configflags (#521)

  [ Leo Arias ]
  * Run the integration tests against a local fake server when the user
    password is not in the environment. (#511) (LP: #1585023)
  * Move the login and logout methods to a client. (#518) (LP: #1586504)
  * Improve the config handling. (#519) (LP: #1586511)
  * Fix the one-time password login. (#529) (LP: #1586832)
  * Moved the download to the store client. (#530) (LP: #1586836)
  * Moved the upload to the store client. (#531) (LP: #1586836)
  * Updated the documentation about the icon. (#542) (LP: #1578231)
  * Improve the error message when a part binary is not found. (#541)
    (LP: #1582367)
  * Reenable the ROS demo for autopackage testing. (#520) (LP: #1588098)
  * Add macaroon support to login, upload and download. (#532) (LP: #1586910)
  * Set the no_proxy environment variable to access the local fake servers.
    (#546) (LP: #1588631)

  [ Stephen Stewart ]
  * nodejs plugin: Support configurable node version (#509) (LP: #1586104)

  [ Kyle Fazzari ]
  * Use correct cross-build packages for ppc64le. (#539) (LP: #1570944)

  [ Sergio Schvezov ]
  * Support zip files as source (#523) (LP: #1577062)
  * A nicer error message for incorrect stage-packages (#524) (LP: #1568131)
  * Support the assumes keyword (#525) (LP: #1586429)
  * Improve the template for snapcraft init (#528) (LP: #1575581)
  * Filter out *.snap from sourcedir (#535) (LP: #1575628)
  * Support setting a gopath for a go project from vcs (#538) (LP: #1583426)
  * Add a ticker for snapping (#540) (LP: #1582955)
  * Rename strip to prime (#543) (LP: #1582515)

  [ Didier Roche ]
  * Wrap plugin list output content (#534) (LP: #1587057)
  * Add snapcraft examples to scaffold getting started tour (#513)
    (LP: #1586137)

  [ Joe Talbott ]
  * Add support for parsing the parts wiki (#545) (LP: #1587583)

 -- Sergio Schvezov <email address hidden> Fri, 03 Jun 2016 13:37:58 -0300

Changed in snapcraft (Ubuntu Yakkety):
status: New → Fix Released

Hello Leo, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapcraft (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Changed in snapcraft:
status: Fix Committed → Fix Released
Leo Arias (elopio) wrote :

Tested in an up-to-date xenial system:
- Enabled the proposed archive
- Updated snapcraft to 2.10
- Made a snapcraft dir.
- snapcraft init
- snapcraft
- The mksquasfs messages are not printed.
- snapcraft --debug
- The mksquasfs messages are printed.

I'm marking the verification as done.

Thanks Chris!

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapcraft - 2.10.1

---------------
snapcraft (2.10.1) xenial; urgency=medium

  * Backwards compatible clean with strip (#556) (LP: #1590256)

 -- Sergio Schvezov <email address hidden> Wed, 08 Jun 2016 16:32:27 -0300

Changed in snapcraft (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers