python-apt in yakkety no longer creates partial

Bug #1578007 reported by Sergio Schvezov on 2016-05-04
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
High
Sergio Schvezov
python-apt (Ubuntu)
High
Julian Andres Klode
snapcraft (Ubuntu)
Undecided
Unassigned
Xenial
Undecided
Unassigned

Bug Description

This now fails: http://paste.ubuntu.com/16208927/
With an error that looks like http://paste.ubuntu.com/16208917/

If 'partial' is created in `downloaddir` then it works again

[Impact]

 * Users of yakkety won't be able to build snaps with stage packages.

 * Users of xenial are not affected.

[Test Case]

Build a snap with stage packages:
 * apt get install snapcraft snapcraft-examples
 * mkdir /tmp/mosquitto
 * cp /usr/share/doc/snapcraft-examples/examples/mosquitto/* /tmp/mosquitto
 * cd /tmp/mosquitto
 * snapcraft

A snap must be generated.

[Regression Potential]

 * The fix in yakkety could affect the version in xenial.

description: updated
Sergio Schvezov (sergiusens) wrote :

Talking to mvo, he mentioned this should be a bug in apt or python-apt

no longer affects: apt (Ubuntu Xenial)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapcraft - 2.8.8+16.10

---------------
snapcraft (2.8.8+16.10) yakkety; urgency=medium

  * Create the 'partial' directory for apt. (#499) (LP: #1578007)

 -- Sergio Schvezov <email address hidden> Wed, 04 May 2016 14:22:58 -0300

Changed in snapcraft (Ubuntu):
status: New → Fix Released
Julian Andres Klode (juliank) wrote :

This is somewhat expected. The code to setup partial was deprecated in APT, we only set the Log in python-apt anymore.

I think I need to provide a binding for GetLock(), which is now supposed to create the partial directory.

affects: apt (Ubuntu) → python-apt (Ubuntu)
Changed in python-apt (Ubuntu):
status: New → Confirmed
Julian Andres Klode (juliank) wrote :

To be precise: It's python-apt 1.1.0~beta2 that introduces the issue in commit e85512376356a769d540f09137a00012d8be7f2d.

Hello Sergio, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.8.8a in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapcraft (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed

Tested in an up-to-date xenial system:
- Enabled the proposed archive
- updated snapcraft to 2.8.8a
- build the mosquitto example.

Works alright.

The fix in the code will work in xenial and yakkety creating the directory when it's not there, and doing nothing when it is in there.

description: updated
description: updated
tags: added: verification-done
removed: verification-needed

Hello Sergio, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.8.8b in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
summary: - apt in yakkety no longer creates partial
+ python-apt in yakkety no longer creates partial
Julian Andres Klode (juliank) wrote :

OK, that should be easy to work on. Once I added a get_lock binding for GetLock(), I can change apt.Cache.fetch_archives() to call get_lock(). It gets a bit more complex if a fetcher is passed in, I'm not sure what do about that - locking on a user-provided fetcher seems wrong to me - APT provides no method to unlock a fetcher.

But let's just figure out the easy thing first, we can look at the other one later on.

Changed in python-apt (Ubuntu):
assignee: nobody → Julian Andres Klode (juliank)
importance: Undecided → High
status: Confirmed → In Progress
Leo Arias (elopio) wrote :

One more time:

Tested in an up-to-date xenial system:
- Enabled the proposed archive
- updated snapcraft to 2.8.8b
- build the mosquitto example.

Works alright. Marking as verification-done.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapcraft - 2.8.8b

---------------
snapcraft (2.8.8b) xenial; urgency=medium

  [ Sergio Schvezov ]
  * Remove missing replacement for unittest.mock (#494) (LP: #1576998)
  * Create the 'partial' directory for apt. (#499) (LP: #1578007)
  * Don't fail if there is no system library list (#496) (LP: #1577750)
  * Don't clean target before extracting npm (#489) (LP: #1575876)
  * Don't delete the nodejs download on build. (#490) (LP: #1575882)

  [ Leo Arias ]
  * Import mock from unittest. (#492) (LP: #1576998)
  * autopkgtests: run the tests using the installed package (#464)
    (LP: #1570992)
  * Remove --allow-unauthenticated from examples tests (#482) (LP: #1573211)
  * Update the assertion of the example install (#483) (LP: #1573243)
  * Examples tests: Update the path to the snaps binaries (#484) (LP: #1573349)
  * Examples tests: use systemctl instead of the removed snap service (#485)
    (LP: #1573697)
  * Update the mosquitto example SNAP_USER_DATA path. (#486) (LP: #1574857)
  * Update the busybox test to use the snap data path. (LP: #1574901)
  * Remove the integration tests coverage. (#488) (LP: #1575383)

  [ Vincent Ladeuil ]
  * Make upload more robust by ignoring spurious errors while polling the
    scan status. (#480) (LP: #1572963)

  [ Kyle Fazzari ]
  * docs/get-started.md: Stop discussing snappy-tools. (#454) (LP: #1568113)

 -- Sergio Schvezov <email address hidden> Fri, 29 Apr 2016 14:59:47 -0300

Changed in snapcraft (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in snapcraft:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers