Copy plugin should follow symlinks that point outside of the snap

Bug #1532515 reported by Renat
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Status tracked in Trunk
Trunk
Fix Released
Low
Kyle Fazzari

Bug Description

We need the option to copy symlinks as symlinks with their metadata in the copy plugin.

Here is the possible solution.

https://github.com/ubuntu-core/snapcraft/pull/209

Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Thanks for the bug, Renat. However, would you mind fleshing it out a little? Give a scenario, expected results, and actual results if possible.

Changed in snapcraft:
status: New → Incomplete
Revision history for this message
Renat (renat2017) wrote :

We build our QT application inside a buildroot with all necessary libraries into squashfs, where it should run in chrooted mode.

To port it into snappy I decided just to copy some folders with copy plugin. That's why I need to copy symlinks as symlinks and not as regular files.

Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Understood Renat, thanks for the information. Yeah, the PR looks good other than the static checks.

Changed in snapcraft:
status: Incomplete → In Progress
importance: Undecided → Low
assignee: nobody → Renat (renat2017)
Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Note that I've targeted trunk for this, which means it'll be in Snapcraft 2.x. If you need it in Snapcraft 1.x please let me know.

Revision history for this message
Kyle Fazzari (kyrofa) wrote :

The copy plugin copies symlinks as of 2.7 as a side effect of another fix, but it needs to make sure it follows symlinks that will be invalid when snapped, so I'll repurpose this bug.

summary: - Copy plugin doesn't copy symlinks
+ Copy plugin should follow symlinks that point outside of the snap
Revision history for this message
Kyle Fazzari (kyrofa) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.