Snapcraft

Help crashes if specified plugin does not exist

Bug #1510954 reported by Daniel Holbach on 2015-10-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ Snapcraft
Fix Released
High
Sergio Schvezov
Snapcraft 0.4
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

daniel@daydream:~/dev/snappy/snapcraft$ ./bin/snapcraft help plugin
The plugin does not exist. Use one of the following:
ant
autotools
catkin
cmake
copy
go
jdk
make
maven
python2
python3
qml
roscore
scons
tar-content
Traceback (most recent call last):
  File "./bin/snapcraft", line 33, in <module>
    snapcraft.main.main()
  File "/home/daniel/dev/snappy/snapcraft/snapcraft/main.py", line 115, in main
    args.func(args)
  File "/home/daniel/dev/snappy/snapcraft/snapcraft/help.py", line 50, in topic
    _module_help(args.topic, args.devel)
  File "/home/daniel/dev/snappy/snapcraft/snapcraft/help.py", line 68, in _module_help
    if module.__doc__ and devel:
UnboundLocalError: local variable 'module' referenced before assignment
daniel@daydream:~/dev/snappy/snapcraft$

Related branches

lp:~sergiusens/snapcraft/1510954
Daniel Holbach (community): Approve on 2015-10-28
Diff: 66 lines (+44/-7)
2 files modified
snapcraft/help.py (+6/-7)
snapcraft/tests/test_help.py (+38/-0)
Sergio Schvezov (sergiusens) on 2015-10-28
Changed in snapcraft:
milestone: none → 0.4
Sergio Schvezov (sergiusens) on 2015-10-28
Changed in snapcraft:
importance: Undecided → High
assignee: nobody → Sergio Schvezov (sergiusens)
status: New → In Progress
Snappy Tarmac (snappydevtarmac) on 2015-10-28
Changed in snapcraft:
status: In Progress → Fix Committed
Leo Arias (elopio) wrote :

Confirmed that there is no traceback anymore.

Sergio Schvezov (sergiusens) wrote :

Released in snapcraft 0.4

Changed in snapcraft:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers