Add support for overriding the Makefile location in makefile part type

Bug #1500759 reported by Zygmunt Krynicki on 2015-09-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Status tracked in Trunk
1.x
Medium
Kyle Fazzari
Trunk
Medium
Kyle Fazzari

Bug Description

For some non-trivial projects, a snapcraft part developer might like to ship a makefile in the source tree of the snap without having to modify an existing source tarball of a 3rd party project. For that use case, the developer could use the optional "makefile" part attribute to override the makefile executed by snapcraft to build that given part.

For example:

parts:
    foo:
        type: makefile
        makefile: Makefile.foo

This would cause snapcraft to run the following command at part build time:

make -f Makefile.foo -C parts/foo/build

Changed in snapcraft:
assignee: nobody → Zygmunt Krynicki (zyga)
milestone: none → 0.3
importance: Undecided → Medium
Changed in snapcraft:
milestone: 0.3 → none
assignee: Zygmunt Krynicki (zyga) → nobody
Leo Arias (elopio) wrote :
Changed in snapcraft:
status: New → Invalid
Changed in snapcraft:
status: Invalid → Triaged
Kyle Fazzari (kyrofa) wrote :

Would using source-subdir here solve this problem?

That is something different.

Some projects do things like this

Makefile.linux
Makefile.osx
Makefile.bsd

and so on, without any magic selection mechanism, so it needs to be
manually set.

Others use different makefiles as "configuration bundles"

On Wed, Jan 20, 2016 at 7:49 AM, Kyle Fazzari <email address hidden> wrote:

> Would using source-subdir here solve this problem?
>
> --
> You received this bug notification because you are a member of Snappy
> Developers, which is subscribed to Snapcraft.
> https://bugs.launchpad.net/bugs/1500759
>
> Title:
> Add support for overriding the Makefile location in makefile part type
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/snapcraft/+bug/1500759/+subscriptions
>
> Launchpad-Notification-Type: bug
> Launchpad-Bug: product=snapcraft; status=Triaged; importance=Medium;
> assignee=None;
> Launchpad-Bug-Information-Type: Public
> Launchpad-Bug-Private: no
> Launchpad-Bug-Security-Vulnerability: no
> Launchpad-Bug-Commenters: elopio kyrofa zyga
> Launchpad-Bug-Reporter: Zygmunt Krynicki (zyga)
> Launchpad-Bug-Modifier: Kyle Fazzari (kyrofa)
> Launchpad-Message-Rationale: Subscriber (Snapcraft) @snappy-dev
> Launchpad-Message-For: snappy-dev
>

Kyle Fazzari (kyrofa) wrote :

Ah sure, that makes sense.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers