Services and binaries allow _ #
Bug #1495662 reported by
Sergio Schvezov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Snapcraft |
Fix Released
|
High
|
Sergio Schvezov | |||
| Snappy | Status tracked in Trunk | |||||
| 15.04 |
Won't Fix
|
High
|
Unassigned | |||
| Trunk |
Fix Released
|
High
|
Unassigned | |||
Bug Description
Services and binaries should not allow _ or #
snapcraft allows to build and disregards the names
snappy on install ignores completely and when installed is rendered useless by an inexistent apparmor profile (_ is reserved for appid, # is not allowed by easy prof)
Related branches
lp:~sergiusens/snapcraft/serviceBinaryNameRegex
- Michael Vogt (community): Approve
-
Diff: 68 lines (+40/-0)2 files modifiedschema/snapcraft.yaml (+2/-0)
snapcraft/tests/test_yaml.py (+38/-0)
| description: | updated |
Revision history for this message
| Jamie Strandboge (jdstrand) wrote | #1 |
| Changed in snapcraft: | |
| assignee: | nobody → Sergio Schvezov (sergiusens) |
| milestone: | none → 0.2 |
| importance: | Undecided → High |
| status: | New → Fix Committed |
| Changed in snapcraft: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Michael Vogt (mvo) wrote | #2 |
Revision history for this message
| Michael Vogt (mvo) wrote | #3 |
Revision history for this message
| Michael Vogt (mvo) wrote | #4 |
To post a comment you must log in.
Obviously fixing snapcraft is appropriate, however there are several other issues related to this. These are all the issues:
1. snapcraft is adding a '_' to the binary/service name (this bug and MP)
2. snappy build isn't erroring out with '_' in the binary/service name
3. snappy install isn't failing/providing feedback that the apparmor profile generation errored out
4. the review tools aren't being run by snappy build/snapcraft (they also would have caught this)