Snapcraft

tests print a lot of warnings when they leave files on the working directory

Bug #1484596 reported by Leo Arias
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
PlainBox (Toolkit)
Fix Released
Medium
Zygmunt Krynicki
PlainBox (Toolkit) 0.23
Snapcraft
Fix Released
Undecided
Zygmunt Krynicki
Snapcraft 0.2

Bug Description

When running the plainbox tests in snapcraft, the output is full of WARNINGS saying something like:
WARNING plainbox.runner: Leftover file/directory: 'default'

It would be nice to be able to hide these warning with a flag.

-------------[ Running job 22 / 22. Estimated time left: 0:00:00 ]--------------
-------------------------[ snapcraft/normal/hg-branch ]-------------------------
ID: 2015.com.canonical.snapcraft::snapcraft/normal/hg-branch
Category: 2013.com.canonical.plainbox::uncategorised
... 8< -------------------------------------------------------------------------
+ cp -rT /home/elopio/workspace/canonical/snapcraft/trunk/integration-tests/data/hg-branch .
+ hg init .
+ hg branch second
marked working directory as branch second
(branches are permanent and global, did you want a bookmark?)
+ touch second
+ hg commit -m second --user 'Example Dev' -A second
+ hg branch default
marked working directory as branch default
(branches are permanent and global, did you want a bookmark?)
+ touch default
+ hg commit -m default --user 'Example Dev' -A default
+ snapcraft-coverage pull
Pulling mercurial
updating to branch second
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
hg clone -u second . /tmp/cwd-n4kkscq1.b70a7984ce60762b9cbcf80518c38a781c8f1998525c88757cfb4bafdba5563d/parts/mercurial/src
cp -Trfa /tmp/cwd-n4kkscq1.b70a7984ce60762b9cbcf80518c38a781c8f1998525c88757cfb4bafdba5563d/parts/mercurial/src /tmp/cwd-n4kkscq1.b70a7984ce60762b9cbcf80518c38a781c8f1998525c88757cfb4bafdba5563d/parts/mercurial/build
+ test -e parts/mercurial/src/second
+ snapcraft-coverage pull
Pulling mercurial
pulling from .
no changes found
hg pull -b second .
cp -Trfa /tmp/cwd-n4kkscq1.b70a7984ce60762b9cbcf80518c38a781c8f1998525c88757cfb4bafdba5563d/parts/mercurial/src /tmp/cwd-n4kkscq1.b70a7984ce60762b9cbcf80518c38a781c8f1998525c88757cfb4bafdba5563d/parts/mercurial/build
+ test -e parts/mercurial/src/second
------------------------------------------------------------------------- >8 ---
WARNING plainbox.runner: Job 2015.com.canonical.snapcraft::snapcraft/normal/hg-branch created leftover filesystem artefacts in its working directory
WARNING plainbox.runner: Leftover file/directory: 'default'
WARNING plainbox.runner: Leftover file/directory: 'second'
WARNING plainbox.runner: Leftover file/directory: 'snapcraft.yaml'
WARNING plainbox.runner: Leftover file/directory: '.hg'
WARNING plainbox.runner: Leftover file/directory: '.hg/undo.dirstate'
WARNING plainbox.runner: Leftover file/directory: '.hg/undo.bookmarks'
WARNING plainbox.runner: Leftover file/directory: '.hg/undo.desc'
WARNING plainbox.runner: Leftover file/directory: '.hg/requires'
WARNING plainbox.runner: Leftover file/directory: '.hg/undo.branch'
WARNING plainbox.runner: Leftover file/directory: '.hg/dirstate'
WARNING plainbox.runner: Leftover file/directory: '.hg/00changelog.i'
WARNING plainbox.runner: Leftover file/directory: '.hg/branch'
WARNING plainbox.runner: Leftover file/directory: '.hg/last-message.txt'
WARNING plainbox.runner: Leftover file/directory: '.hg/cache'
WARNING plainbox.runner: Leftover file/directory: '.hg/cache/branch2-served'
WARNING plainbox.runner: Leftover file/directory: '.hg/cache/tags'
WARNING plainbox.runner: Leftover file/directory: '.hg/store'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/00manifest.i'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/phaseroots'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/undo.phaseroots'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/undo'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/00changelog.i'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/fncache'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/data'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/data/default.i'
WARNING plainbox.runner: Leftover file/directory: '.hg/store/data/second.i'
WARNING plainbox.runner: Leftover file/directory: 'snap'
WARNING plainbox.runner: Leftover file/directory: 'stage'
WARNING plainbox.runner: Leftover file/directory: 'parts'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/state'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/second'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/hgrc'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/requires'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/dirstate'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/00changelog.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/branch'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/store'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/store/00manifest.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/store/00changelog.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/store/fncache'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/store/data'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/store/data/default.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/build/.hg/store/data/second.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/second'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/hgrc'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/requires'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/dirstate'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/00changelog.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/branch'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/store'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/store/00manifest.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/store/00changelog.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/store/fncache'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/store/data'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/store/data/default.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/src/.hg/store/data/second.i'
WARNING plainbox.runner: Leftover file/directory: 'parts/mercurial/install'
WARNING plainbox.runner: Please store desired files in $PLAINBOX_SESSION_SHARE and use regular temporary files for everything else
Outcome: job passed

Tags: snapcraft

Related branches

lp:~zyga/snapcraft/fix-1484596
Sergio Schvezov: Approve
Diff: 257 lines (+2/-55)
2 files modified
integration-tests/units/jobs.pxu (+1/-54)
integration-tests/units/testplans.pxu (+1/-1)
lp:~zyga/checkbox/fix-1484596
Sylvain Pineau: Approve
Leo Arias (community): Approve
Diff: 79 lines (+27/-2)
4 files modified
plainbox/docs/changelog.rst (+5/-0)
plainbox/docs/manpages/plainbox-job-units.rst (+9/-0)
plainbox/plainbox/impl/runner.py (+4/-2)
plainbox/plainbox/impl/unit/job.py (+9/-0)
lp:ubuntu/wily-proposed/snapcraft
Leo Arias (elopio)
tags: added: snapcraft
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Yes, as discussed we can add a flag that lets plainbox know this is the expected behavior of the test.

Changed in plainbox:
status: New → Triaged
Zygmunt Krynicki (zyga)
Changed in plainbox:
assignee: nobody → Zygmunt Krynicki (zyga)
Changed in snapcraft:
assignee: nobody → Zygmunt Krynicki (zyga)
Changed in plainbox:
status: Triaged → In Progress
Changed in snapcraft:
status: New → In Progress
Zygmunt Krynicki (zyga)
Changed in plainbox:
importance: Undecided → Medium
Zygmunt Krynicki (zyga)
Changed in plainbox:
milestone: none → 0.23
Daniel Holbach (dholbach)
Changed in snapcraft:
milestone: none → 0.2
Daniel Holbach (dholbach)
Changed in snapcraft:
status: In Progress → Fix Released
Sylvain Pineau (sylvain-pineau)
Changed in plainbox:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.