mount-ns-layout test sometimes fails

[Zygmunt Krynicki]

This is just so that we don't lose track of this odd failure. This test fails randomly, it fails because the /var/lib/cloud directory doesn't show up in the mount table. That directory is created with the quirks code and interestingly it is the only directory that differs between the 'ubuntu-core' and 'core' snaps. This might be a race or perhaps some missing cleanup from the earlier test. I never managed to reproduce it by running that one failing test in a loop.

2016/11/24 12:16:50 Error executing linode:ubuntu-16.04-64-grub:spread-tests/main/mount-ns-layout :
-----
+ snapd-hacker-toolbelt.busybox true
+ ./process.py
+ nsenter -m/run/snapd/ns/snapd-hacker-toolbelt.mnt cat /proc/self/mountinfo
+ '[' -e /snap/core/current ']'
+ cmp observed.json expected.classic.core.json
observed.json expected.classic.core.json differ: byte 10098, line 455
-----
2016/11/24 12:16:53 Error debugging linode:ubuntu-16.04-64-grub:spread-tests/main/mount-ns-layout :
-----
+ '[' -e /snap/core/current ']'
+ diff -u observed.json expected.classic.core.json
--- observed.json 2016-11-24 12:16:47.922688532 +0000
+++ expected.classic.core.json 2016-11-24 12:07:43.000000000 +0000
@@ -452,16 +452,6 @@
   {
     "fs_type": "squashfs",
     "mount_opts": "rw,relatime",
- "mount_point": "/var/lib/cloud",
- "mount_src": "/dev/remapped-loop0",
- "opt_fields": [
- "master:renumbered/0"
- ],
- "root_dir": "/var/lib/cloud"
- },
- {
- "fs_type": "squashfs",
- "mount_opts": "rw,relatime",
     "mount_point": "/var/lib/console-conf",
     "mount_src": "/dev/remapped-loop0",
     "opt_fields": [
+ :
+ apt-get install pastebinit
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
  pastebinit
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 14.6 kB of archives.
After this operation, 160 kB of additional disk space will be used.
Get:1 http://mirrors.linode.com/ubuntu xenial/main amd64 pastebinit all 1.5-1 [14.6 kB]
Fetched 14.6 kB in 0s (0 B/s)
Selecting previously unselected package pastebinit.
(Reading database ... 39432 files and directories currently installed.)
Preparing to unpack .../pastebinit_1.5-1_all.deb ...
Unpacking pastebinit (1.5-1) ...
Processing triggers for man-db (2.7.5-1) ...
Setting up pastebinit (1.5-1) ...
+ pastebinit
+ nsenter -m/run/snapd/ns/snapd-hacker-toolbelt.mnt cat /proc/self/mountinfo
http://paste.ubuntu.com/23526957/
+ grep DENIED
+ dmesg
-----

[Zygmunt Krynicki (zyga)]

The snap-confine project was merged into snapd long time ago. This test no longer exists and, ironically, the reasons for the failure is understood as other tests not cleaning up after themselves.