smart unusable with some header files

[not saying]

I'm using Mandriva 2010.0 and Smart 1.2 (the bug was observed on 1.3, too).
I recently re-added my repositories. After that, every attempt to upgrade ended up with "Package list with no CRPMTAG_FILENAME tag" message and my changes forgotten. Smart was unusable because of that.

I made a workaround for this problem, in form of a pseudo-patch, attached. Smart will fall back to the default method of retrieving the file name if the header lacks [CRPMTAG_FILENAME]. The culprit may be the repository owner, but smart doesn't handle their fault gracefully. Attached my list of channels.

[Anders F Björklund (afb)]

Repository sounds broken, but deferring to the urpmi rewrites.

[Anders F Björklund (afb)]

Can't reproduce this problem with that channel list. If it happens again, could you try to determine the headerlist file ?

         if not filename:
+ iface.debug(self._filename)
             raise Error, _("Package list with no CRPMTAG_FILENAME tag")

We get the same problem on other backends, when repositories checksum and sign bogus data (e.g. broken XML)

Not sure if Smart should try to limp along, or Error and abort (like it currently does) so that you can disable the channel