/proc/mounts shouldn't be required
Bug #337802 reported by
Anders F Björklund
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Smart Package Manager |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
/proc/mounts shouldn't be required, as it is only available on Linux.
for now it would be OK to return isMounted=False instead of raising,
but eventually it should probably use the mount(8) output instead...
Related branches
lp:~afb/smart/solaris
(Merged)
tags: | added: solaris |
tags: | added: freebsd |
Changed in smart: | |
milestone: | none → 1.3 |
Changed in smart: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
As we discussed online, I'm a bit uncomfortable with simply returning False if it's not found. I'd like to see what the errors look like, and handle it appropriately. Blindly returning False on isMounted() and keeping everything else as is may present side-effects such as trying to mount an already mounted partition. If /proc/mounts isn't available on some operating systems where Smart is wanted, let's implement correct isMounted() support on them instead.