Fedora's unicode RPM dependencies

Bug #337798 reported by Anders F Björklund
2
Affects Status Importance Assigned to Milestone
Smart Package Manager
Fix Released
Undecided
Unassigned
smart (Fedora)
Fix Released
High

Bug Description

rpm-4.6.0-7 allows unicode in provides and other dependencies, which causes "str". vs "unicode" issues in Smart / buildPackage().

TypeError: argument 1 must be str, not unicode

Tags: fedora

Related branches

Changed in smart:
milestone: none → 1.3
Revision history for this message
In , Need (need-redhat-bugs) wrote :

Description of problem:
'smart update' and 'smart --gui' abort with stack trace after adding
"bleeding edge" repositories.

Version-Release number of selected component (if applicable):
# smart --version
smart 1.1.1

How reproducible:
currently happens with every attempt to update, but it may depend on the repositories the user has loaded and the contents of those repositories

Steps to Reproduce:
1. - add updates-testing or development-source repository to smart
2. smart update
3. - observe exception

Actual results:
Traceback (most recent call last):
  File "/usr/bin/smart", line 195, in <module>
    main(sys.argv[1:])
  File "/usr/bin/smart", line 168, in main
    exitcode = iface.run(opts.command, opts.argv)
  File "/usr/lib64/python2.5/site-packages/smart/interface.py", line 53, in run
    result = _command.main(self._ctrl, opts)
  File "/usr/lib64/python2.5/site-packages/smart/commands/update.py", line 77, in main
    ctrl.reloadChannels()
  File "control.py", line 387, in reloadChannels
  File "/usr/lib64/python2.5/site-packages/smart/backends/rpm/metadata.py", line 294, in load
    prvargs, reqargs, upgargs, cnfargs)
TypeError: argument 1 must be str, not unicode

Expected results:
smart update completes without error

Additional info:
probably same issue as reported here:
   https://bugs.launchpad.net/smart/+bug/337798

Revision history for this message
In , Need (need-redhat-bugs) wrote :

these are the specific packages I have installed:

# rpm -qa | grep smart-
smart-gui-1.1-59.0.1.fc10.x86_64
smart-1.1-59.0.1.fc10.x86_64
fedora-package-config-smart-10-15.x86_64

Changed in smart:
status: Unknown → Confirmed
Revision history for this message
Anders F Björklund (afb) wrote :
Revision history for this message
In , Need (need-redhat-bugs) wrote :

Someone added a patch to the other bug I linked:
http://launchpadlibrarian.net/23697017/smart-unicode-provides.diff

Applying this patch fixes the problem. [You will have to adjust the line numbers in the patch, but the fix is straightforward.]

Revision history for this message
In , Axel (axel-redhat-bugs) wrote :

The upstream bug for this one is

https://bugs.launchpad.net/smart/+bug/337798

The unicode vs str issue was expected to appear in F11 and later, I think that the development-source channel triggered this bug for you, e.g. it is not an F10 bug, but an F11 bug (OTOH building a rawhide chroot within an F10/F9 host will trigger this bug as well).

If I am wrong, please change the version field back to F10 and raise the severity!!!

Changed in smart:
status: Confirmed → In Progress
Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

smart-1.2-63.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/smart-1.2-63.fc10

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

smart-1.2-63.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/smart-1.2-63.fc9

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

smart-1.2-64.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with
 su -c 'yum --enablerepo=updates-testing-newkey update smart'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3736

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

smart-1.2-64.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with
 su -c 'yum --enablerepo=updates-testing update smart'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3738

Changed in smart (Fedora):
status: In Progress → Fix Committed
Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

smart-1.2-64.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

smart-1.2-64.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.

Changed in smart (Fedora):
status: Fix Committed → Fix Released
tags: added: fedora
Changed in smart:
milestone: 1.3 → 1.2.1
Changed in smart:
status: New → Fix Committed
Changed in smart:
status: Fix Committed → Fix Released
Changed in smart (Fedora):
importance: Unknown → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.