Support Python 2.6 too

Bug #292542 reported by Anders F Björklund
28
Affects Status Importance Assigned to Milestone
Smart Package Manager
Fix Released
Undecided
Gustavo Niemeyer
openSUSE
Invalid
Medium

Bug Description

To support Python 2.6, as well as current Python 2.3 - 2.5,
the "md5" routines need to check for module "hashlib" first.
http://www.python.org/doc/2.3/lib/module-md5.html
http://www.python.org/doc/2.5/lib/module-hashlib.html

There might be more changes needed for Python 2.6 too...

Related branches

Revision history for this message
In , Stbinner (stbinner) wrote :

Smart is not part of the openSUSE 11.1, please report the report to whereever you got it from.

Revision history for this message
In , Felix Miata (mrmazda) wrote :
Revision history for this message
Anders F Björklund (afb) wrote :

To support Python 2.6, as well as current Python 2.3 - 2.5,
the "md5" routines need to check for module "hashlib" first.
http://www.python.org/doc/2.3/lib/module-md5.html
http://www.python.org/doc/2.5/lib/module-hashlib.html

There might be more changes needed for Python 2.6 too...

Revision history for this message
Anders F Björklund (afb) wrote :
Changed in smart:
milestone: none → 1.2
Revision history for this message
Anders F Björklund (afb) wrote :

Same thing, but for "sha" instead of "md5"

Revision history for this message
In , Felix Miata (mrmazda) wrote :

*** Bug 461740 has been marked as a duplicate of this bug. ***

Revision history for this message
In , Marko Schugardt (sapex) wrote :

Did a bug report at Labix: http://tracker.labix.org/issue385

Changed in smart:
milestone: 1.2 → 1.1.2
Revision history for this message
Anders F Björklund (afb) wrote :
Revision history for this message
Marko Schugardt (sapex) wrote :

The problem still exists on openSUSE 11.1 (i586).

Revision history for this message
Anders F Björklund (afb) wrote :

Problem still exists with the patches applied, or you mean a problem exists with getting them applied... ?

Revision history for this message
Marko Schugardt (sapex) wrote :
Revision history for this message
Marko Schugardt (sapex) wrote :

At least the smart-py26.diff patch is in the package as far as I can see.

:~> smart channel --show
/usr/lib/python2.6/site-packages/smart/plugins/zyppchannelsync.py:22: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  import md5
[...]

Revision history for this message
Anders F Björklund (afb) wrote :

Right, smart-py26.diff is in the package but they are missing the patch for their zyppsync addition... (Comment 4, above).

i.e. delete the "import md5" line, since it's not being used anyway. There's some other fixes in the upstream zyppsync too.

Revision history for this message
Anders F Björklund (afb) wrote :
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

The python26 branch from Anders has been merged as-is.

Changed in smart:
assignee: nobody → niemeyer
status: New → Fix Committed
Revision history for this message
Anders F Björklund (afb) wrote :

Released, 2009-03-04

Changed in smart:
status: Fix Committed → Fix Released
Revision history for this message
In , Felix Miata (mrmazda) wrote :

As per comment 1 this is no longer valid.

Changed in opensuse:
importance: Unknown → Medium
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.