smart --gui segfaults when no X display available

[Rehan Khan]

Imported: http://tracker.labix.org/issue284

Reason: Bug

further details: https://blueprints.launchpad.net/smart/+spec/bug-reporting-migration

msg1440 (view) Author: rasker Date: 2008-07-01.11:51:15

Tested with 0.52 on Fedora 8. Although smart doesn't segfault it doesn't catch a
failure to attach to a Display gracefully and outputs a trace.

msg1084 (view) Author: dvgevers Date: 2007-01-31.21:50:05

smart --gui segfaults when no X display available. Obviously.

I can understand that it does not work, but it should give a warning or an error
message and exit gracefully: it should not segfault:

This was previously reported downstream as
http://qa.mandriva.com/show_bug.cgi?id=27187

Strace is attached. stdout may be viewed at that URL.

smart version is 0.50.2mdv2007.1 (Mandriva Cooker)

[netmask (netmask)]

The attached patch makes sure GTK can open a valid display, and in case not, Smart dies gracefully.

[Glenn D. (doiggl-hotmail)]

On error could a terminal be used instead as a fail over option ?