Timeout parameter missing in scserve when creating smart server

[Servilio Afre Puentes]

The repository server doesn't work at all because of this. Adding the missing parameter solves the issue.

[Jeffery von Ronne (vonronne)]

I think this may be connected to an API change in bzr 2.5b2:

"Plugins that implement custom protocols for bzr serve should now also take an argument timeout. This is used by the the bzr protocol to close a connection if a client has been idle for more than X seconds. (Default 5minutes). (John Arbash Meinel)"

http://doc.bazaar.canonical.com/bzr.dev/en/release-notes/bzr-2.5.html#id45

It seems no default is being supplied, at least in bzr 2.5.1-0ubuntu2 from precise-updates as the server is being invoked by sc smart server. A natural place for the default to have been supplied would be in the parameters of the __init__ method
for SmartServerPipeStreamMedium on line 425 of /usr/lib/python2.7/dist-packages/bzrlib/smart/medium.py.

[Thierry Durandy (tdurandy)]

Being locked, I made this dummy patch into .../sloecode/bzrplugins/scserve/__init__.py line 56 :

        if inet:
            # Limit sessions to 1 hour
            timeout=3600.0
            smart_server = medium.SmartServerPipeStreamMedium(
                sys.stdin, sys.stdout, transport, timeout)