Status Message Handler always ignores login

[Thomas Berezansky]

Due to MsgType not having an account field handle_sc_status should be checking $server, not $self, for account information. As a result of checking the wrong field handle_sc_status always assumes the session is not logged in and returns status based on the first account. When this account is not flagged for some capabilities and the client expects/needs those capabilities the client may determine it can't function and disconnect, even though the login actually has those capabilities.

Furthermore, checking if $server->{account} exists will fail when $server->{account} has been set to undef. Instead I believe we should be checking if $server->{account} is defined.

I have placed fixes for both in the following branch:

http://git.evergreen-ils.org/?p=working/SIPServer.git;a=shortlog;h=refs/heads/user/tsbere/server_not_self

[Galen Charlton (gmc)]

I have tested and pushed a sign-off branch that squashes the two patches to user/gmcharlt/lp1463459_signed_off in the working/SIPServer repository. However, see bug 1464748; the pull request for that will include the patch for this bug.