Variable fields can be too long per SIP2 specification
Bug #1070470 reported by
Jason Stephenson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| SIPServer |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
The add_field method in Sip.pm does no checking of the length of a variable field added to a message. The SIP2 protocol specifications specifies that variable fields are from 0 to 255 characters excluding the field identifier and field delimiter.
This branch adds an if statement to the add_field method to truncate fields greater than 255 characters in length. I don't know that anyone has seen these in the wild, but it is better to be proactively defensive.
The branch is at http://
| tags: | added: pullrequest |
| Changed in sipserver: | |
| status: | New → Confirmed |
Revision history for this message
| Jason Stephenson (jstephenson) wrote | #1 |
Revision history for this message
| Galen Charlton (gmc) wrote | #2 |
| Changed in sipserver: | |
| importance: | Undecided → Low |
| status: | Confirmed → Fix Committed |
| Changed in sipserver: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Just a note that we've been running this in production for over a month now, and it has fixed a problem that one of our member library's reported with intermittent failures of fine item details. Some of those would output over 255 byte fields without this branch.