"Send preview" with no adress sends to the whole channel

[David Jensen]

Hi,
this might already be solved but I couldn't find a bugreport nor any mention of it in the changelog.
I'm on version 0.8.11

The problem is that if you press "Send as preview" button without having specified a address it will happily send to the entire channel instead, seems a bit dangerous.

To reproduce:
#1 Select "Send as newsletter" on an article
#2 Select a channel
#3 Press "Send as preview"

Thanks
/david

[Xaig (xavi-aigua)]

To resolve this bug you can make a check of the address field in the code.
In file collective/dancing/browser/sendnewsletter.py, line 231 (inside the function handle_preview) you can add the checker test as follows:
        address = data['address']
        if not address:
            self.status = 'The address to send the preview is missing.'
            return

[Maurits van Rees (maurits-vanrees)]

Fixed in revision 118436 of collective.dancing.