"Send preview" with no adress sends to the whole channel

Reported by David Jensen on 2010-01-19
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Singing & Dancing
Undecided
Unassigned

Bug Description

Hi,
this might already be solved but I couldn't find a bugreport nor any mention of it in the changelog.
I'm on version 0.8.11

The problem is that if you press "Send as preview" button without having specified a address it will happily send to the entire channel instead, seems a bit dangerous.

To reproduce:
#1 Select "Send as newsletter" on an article
#2 Select a channel
#3 Press "Send as preview"

Thanks
/david

Xaig (xavi-aigua) wrote :

To resolve this bug you can make a check of the address field in the code.
In file collective/dancing/browser/sendnewsletter.py, line 231 (inside the function handle_preview) you can add the checker test as follows:
        address = data['address']
        if not address:
            self.status = 'The address to send the preview is missing.'
            return

Fixed in revision 118436 of collective.dancing.

Changed in singing-dancing:
status: New → Fix Committed
Changed in singing-dancing:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers