| 2008-09-02 09:12:19 |
Daniel Nouri |
description |
This view is in dancing.browser.preview.
It does not render items that are in the collector, only the context object. Compare with the message sending preview that *does* take those items into account.
Also, but less important:
- The preview view makes the assumption that messages will be sent in HTML format. Naturally, this won't be always true. Maybe we should rename it (and relabel in the UI) to HTMLPreviewView, and not make it available if there's no 'html' composer available. Although the composer doesn't even come into play here when rendering, it would make sense to me not to display "preview as HTML" when the message is in fact not going to be sent this way. (Renderers for SMS might display the items completely different, giving a false preview.)
- The preview form as it is could be merged with sendnewsletter.py. |
We want the in-browser preview to use the e-mail address as is used for sending out previews. This will make the display of the collector items more accurate. This is a source of confusion right now.
Original report (from back when the preview didn't render any collector items):
This view is in dancing.browser.preview.
It does not render items that are in the collector, only the context object. Compare with the message sending preview that *does* take those items into account.
Also, but less important:
- The preview view makes the assumption that messages will be sent in HTML format. Naturally, this won't be always true. Maybe we should rename it (and relabel in the UI) to HTMLPreviewView, and not make it available if there's no 'html' composer available. Although the composer doesn't even come into play here when rendering, it would make sense to me not to display "preview as HTML" when the message is in fact not going to be sent this way. (Renderers for SMS might display the items completely different, giving a false preview.)
- The preview form as it is could be merged with sendnewsletter.py. |
|
