Improve caching results.

Bug #227799 reported by David Picó
4
Affects Status Importance Assigned to Milestone
Singing & Dancing
New
Wishlist
Unassigned

Bug Description

The collector needs to be clever about caching results

Changed in singing-dancing:
importance: Undecided → Wishlist
Revision history for this message
Daniel Widerin (saily) wrote :

i've created a new branch on repository and added my first caching implementation for collector-creation in newsletter send method. http://dev.plone.org/collective/changeset/71082

feedback welcome...

Revision history for this message
Daniel Nouri (daniel.nouri) wrote :

Thanks, the implementation looks almost perfect. The last problem I'm seeing with it is that it's expecting the type of metadata['cue'] to be of type datetime. Strictly speaking, only the collector knows what its type is though. So I'd suggest we move the caching to collective.dancing.collector.Collector.get_items. Maybe it'll be a bit harder to cache on the request since it's not a view. But in the end, it'll make for a more robust implementation that'll also support collectors that don't use datetime as their metadata['cue'].

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.