Simplicity

Language breaks code for non-english browsers

Bug #181971 reported by Maxximus
2
Affects Status Importance Assigned to Milestone
Simplicity
Fix Released
Critical
John Le Drew
Simplicity 0.1-dev "Butch Coolidge"
Old
Fix Released
Critical
John Le Drew
Simplicity 0.1-dev "Butch Coolidge"
Stable
Fix Released
Critical
John Le Drew
Simplicity 0.1-dev "Butch Coolidge"

Bug Description

In core/request/request.php line 55 $lang[1] is not set for single HTTP_ACCEPT_LANGUAGE values. To circumvent this, change line 55 to:
  $this->client['language'] = $lang[0].'-'.strtoupper(isset($lang[1]) ? $lang[1] : $lang[0]);

Tags: i18n request
Revision history for this message
John Le Drew (antz29) wrote :

Thanks for that. Could you drop me an e-mail so we can talk about your future involvement? Many thanks, John

Revision history for this message
John Le Drew (antz29) wrote :

This should be fixed. Uploaded change to revision 4.

Cheers

John

Changed in simplicity:
assignee: nobody → antz29
importance: Undecided → Critical
milestone: none → 2.0
status: New → Fix Committed
Revision history for this message
Maxximus (maxximus007) wrote : Re: [Bug 181971] Re: Language breaks code for non-english browsers

Great! Thanks John.

PS: Is your email working?

Revision history for this message
John Le Drew (antz29) wrote :

Try my alternative e-mail jp AT gmail

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.