[SRU] openstack mirror with keystone v3 always imports new images
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
simplestreams |
Fix Released
|
High
|
David Ames | ||
simplestreams (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Xenial |
Won't Fix
|
Undecided
|
Unassigned | ||
Artful |
Won't Fix
|
Medium
|
Unassigned | ||
Bionic |
Fix Released
|
Medium
|
Unassigned | ||
Disco |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
On every execution of /etc/cron.
This will potentially lead to the inability to upload new images due to not having enough free space.
[Test Case]
* deploy artful-pike
juju deploy ./artful-pike.yaml # http://
* Wait until glance-
* Verify the images are in glance running "openstack image list"
* Run the synchronization script again
juju ssh glance-
Expected results:
"openstack image list" prints the same list of images as before running the synchronization script for the 2nd time
Actual result:
"openstack image list" prints a list of images duplicates, e.g.:
$ openstack image list
+------
| ID | Name | Status |
+------
| 7f946cbf-
| 7a5afbf8-
| c9a1dfbd-
| a731c994-
+------
[Potential Regression]
* this patch allows simplestreams to connect to swift and verify if the image was already uploaded or not, any possible regression will manifest around the ability of simplestreams to connect to swift.
[Other Info]
When using the newly added (revno 450) v3 support for mirroring to openstack simplestreams will not notice that images already exist in glace. The result is that every 'sync' will import all new images.
The issue was simply that the tenant_id was not being correctly passed through to the glance query.
It ended considering only existing images that were owned by None, which didn't match anything.
Note:
* This bug is present in Artful when using the v3 keystone api. It is *not* present in xenial or zesty as they do not have v3 keystone support, and the code that is submitted for merge request has the fix included.
Related branches
- Server Team CI bot: Approve (continuous-integration)
- simplestreams-dev: Pending requested
-
Diff: 38 lines (+12/-4)2 files modifiedsimplestreams/objectstores/swift.py (+8/-3)
simplestreams/openstack.py (+4/-1)
- Rafael David Tinoco (community): Disapprove
- Bryce Harrington (community): Approve
- Felipe Reyes (community): Approve
- Edward Hope-Morley: Pending requested
-
Diff: 1851 lines (+1732/-11)10 files modifieddebian/changelog (+15/-0)
debian/patches/428-do-not-require-that-hypervisor_config-be-present.patch (+23/-0)
debian/patches/433-glance-ignore-inactive-images.patch (+42/-0)
debian/patches/435-glance-refactor-for-testing.patch (+853/-0)
debian/patches/436-glance-fix-race-conditions.patch (+479/-0)
debian/patches/450-453-454-keystone-v3-support.patch (+13/-10)
debian/patches/455-nova-lxd-support-squashfs-images.patch (+230/-0)
debian/patches/460-glance-handle-v2-auth-with-sessions.patch (+33/-0)
debian/patches/series (+8/-1)
debian/patches/skip-openstack-tests-if-no-libs.patch (+36/-0)
- Billy Olsen (community): Approve
- Scott Moser (community): Needs Resubmitting
- Felipe Reyes: Pending requested
- Eric Desrochers: Pending requested
-
Diff: 380 lines (+342/-0)6 files modifieddebian/changelog (+8/-0)
debian/patches/460-glance-handle-v2-auth-with-sessions.patch (+33/-0)
debian/patches/keystone-v3-1719879.patch (+35/-0)
debian/patches/keystone-v3-1728982.patch (+32/-0)
debian/patches/nova-lxd-support-squashfs-images.patch (+230/-0)
debian/patches/series (+4/-0)
- Rafael David Tinoco (community): Disapprove
- Billy Olsen (community): Approve
- Scott Moser (community): Needs Resubmitting
- Felipe Reyes (community): Approve
- Eric Desrochers: Pending requested
-
Diff: 1845 lines (+1729/-11)10 files modifieddebian/changelog (+12/-0)
debian/patches/428-do-not-require-that-hypervisor_config-be-present.patch (+23/-0)
debian/patches/433-glance-ignore-inactive-images.patch (+42/-0)
debian/patches/435-glance-refactor-for-testing.patch (+853/-0)
debian/patches/436-glance-fix-race-conditions.patch (+479/-0)
debian/patches/450-453-454-keystone-v3-support.patch (+13/-10)
debian/patches/455-nova-lxd-support-squashfs-images.patch (+230/-0)
debian/patches/460-glance-handle-v2-auth-with-sessions.patch (+33/-0)
debian/patches/series (+8/-1)
debian/patches/skip-openstack-tests-if-no-libs.patch (+36/-0)
Changed in simplestreams: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → David Ames (thedac) |
Changed in simplestreams: | |
status: | In Progress → Fix Committed |
Changed in simplestreams (Ubuntu): | |
status: | New → Fix Released |
importance: | Undecided → High |
Changed in simplestreams (Ubuntu Artful): | |
status: | New → Confirmed |
Changed in simplestreams (Ubuntu Bionic): | |
status: | Fix Released → Confirmed |
Changed in simplestreams (Ubuntu Artful): | |
importance: | Undecided → Medium |
description: | updated |
tags: | added: cpe-onsite |
description: | updated |
summary: |
- openstack mirror with keystone v3 always imports new images + [SRU] openstack mirror with keystone v3 always imports new images |
Changed in simplestreams (Ubuntu Artful): | |
status: | Confirmed → Won't Fix |
Changed in simplestreams (Ubuntu Xenial): | |
status: | New → Fix Released |
status: | Fix Released → In Progress |
assignee: | nobody → Rafael David Tinoco (rafaeldtinoco) |
Changed in simplestreams (Ubuntu Disco): | |
status: | New → Fix Released |
Changed in simplestreams (Ubuntu Bionic): | |
importance: | High → Medium |
Changed in simplestreams (Ubuntu): | |
importance: | High → Medium |
Changed in simplestreams (Ubuntu Xenial): | |
status: | In Progress → Won't Fix |
Changed in simplestreams (Ubuntu Bionic): | |
status: | Fix Released → In Progress |
Changed in simplestreams (Ubuntu Xenial): | |
assignee: | Rafael David Tinoco (rafaeldtinoco) → nobody |
Changed in simplestreams (Ubuntu Bionic): | |
assignee: | nobody → Rafael David Tinoco (rafaeldtinoco) |
Changed in simplestreams (Ubuntu Bionic): | |
status: | In Progress → Fix Released |
assignee: | Rafael David Tinoco (rafaeldtinoco) → nobody |
This bug was fixed in the package simplestreams - 0.1.0~bzr454- 0ubuntu1
--------------- bzr454- 0ubuntu1) bionic; urgency=medium
simplestreams (0.1.0~
* New upstream snapshot.
- Support using older swift clients (older than Ocata).
[David Ames] (LP: #1719879)
- Fix glance sync always uploading new image with keystone v3 auth.
[David Ames] (LP: #1728982)
- tox.ini: Pin versions of style check tools used in flake8 env.
- flake8: remove usage of bare except.
-- Scott Moser <email address hidden> Tue, 31 Oct 2017 10:15:41 -0400