Simple Scan uses a headerbar in Cinnamon

Bug #1644813 reported by Clement Lefebvre on 2016-11-25
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Simple Scan
Fix Released
Medium
Unassigned
3.20
Fix Committed
Medium
Unassigned
3.22
Fix Committed
Medium
Unassigned
simple-scan (Ubuntu)
Medium
Unassigned

Bug Description

Hi,

Please add Cinnamon to the list of DEs where a headerbar shouldn't be used. It doesn't fit that environment.

In src/ui.vala's load() function:

if (is_desktop ("Unity") || is_desktop ("XFCE") || is_desktop ("MATE") || is_desktop ("LXDE"))

should be:

if (is_desktop ("Unity") || is_desktop ("XFCE") || is_desktop ("MATE") || is_desktop ("LXDE") || is_desktop ("X-Cinnamon") || is_desktop ("Cinnamon"))

To reproduce, run:

XDG_CURRENT_DESKTOP="X-Cinnamon" simple-scan

The expected result is a traditional titlebar+menubar, not a headerbar.

Thanks.

Robert Ancell (robert-ancell) wrote :

I've committed that change to trunk, was there an older series this would be useful on?

Changed in simple-scan:
status: New → Fix Committed
importance: Undecided → Medium
milestone: none → 3.23.1
milestone: 3.23.1 → 3.23.2
Changed in simple-scan:
status: Fix Committed → Fix Released
Changed in simple-scan (Ubuntu):
status: New → Fix Committed
importance: Undecided → Medium
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package simple-scan - 3.23.2-0ubuntu1

---------------
simple-scan (3.23.2-0ubuntu1) zesty; urgency=medium

  * New upstream release:
    - Add optional tags in PDF output to be more PDF/A compliant
    - Don't use GtkHeaderBar in Cinnamon (LP: #1644813)
  * debian/control:
    - Bump Standards-Version to 3.9.8 (no changes required).

 -- Robert Ancell <email address hidden> Mon, 28 Nov 2016 23:15:53 +1300

Changed in simple-scan (Ubuntu):
status: Fix Committed → Fix Released

Thanks Robert.

It would be useful in Xenial if possible.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers