Distributed generated .c files require colord / packagekit even if not configured

Bug #1462769 reported by zdpo
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Simple Scan
Fix Released
Medium
Unassigned

Bug Description

I tried to build simple-scan-3.17.2 on opensuse 13.2.
./autogen.sh produce no error - just asked to run make.
But make failed becuase of missing include colord.h...

Please add check to installation of colord-devel package to configure test...

Revision history for this message
Robert Ancell (robert-ancell) wrote : Re: Distributed generated .c files require colord even if configure didn't detect it

This is due to autotools distributing the generated .c file that come from the .vala files. On my build machine I had colord installed so these were generated with that enabled.

I've never been able to find a good method of not distributing the .c files or making sure they are regenerated. I'll have to keep trying to find one...

summary: - autogen.sh /configure no check for presence of colord-devel package
+ Distributed generated .c files require colord even if configure didn't
+ detect it
Changed in simple-scan:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Robert Ancell (robert-ancell) wrote :

As a workaround deleting src/simple_scan_vala.stamp will trigger a rebuild.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Also, running make clean will remove the .c files.

So you can do the following:
$ ./configure
$ make clean
$ make

Revision history for this message
Robert Ancell (robert-ancell) wrote :
Revision history for this message
Pacho Ramos (pacho) wrote :

Usually running touch over offending .c files can also make them to be regenerated (I think we have seen this problem recently with other package downstream and we solved it in that way)

summary: - Distributed generated .c files require colord even if configure didn't
- detect it
+ Distributed generated .c files require colord / packagekit even if
+ configure didn't detect it
summary: - Distributed generated .c files require colord / packagekit even if
- configure didn't detect it
+ Distributed generated .c files require colord / packagekit even if not
+ configured
Revision history for this message
Philipp Wolfer (phw) wrote :

Even when building from source it adds the dependency to packagekit-glib2.vapi even if packagekit is disabled. Same for colord.vapi

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Switched from autotools to Meson - this problem should no longer occur.

Changed in simple-scan:
status: Triaged → Fix Released
Revision history for this message
Jan Steffens (heftig) wrote :

Is this really "Released"? Stable 3.24.0 still suffers from this bug, and I can't recompile the Vala code because of:

ui.vala:456.42-456.45: error: Argument 1: Cannot pass value to reference or output parameter
                    device_model.remove (iter);
                                         ^^^^
ui.vala:469.34-469.37: error: Argument 1: Cannot pass value to reference or output parameter
            device_model.remove (iter);
                                 ^^^^

which I assume is because the code is incompatible with Vala 0.36.

3.24.0 doesn't have the mentioned Meson support, either.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Simple Scan 3.25.1 uses Meson (3.24 will continue to use autotools).

See bug 1686083 for the issue with Vala 0.36 binding changes.

Changed in simple-scan:
milestone: none → 3.25.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.