service_sub_previewer renders first paragraph incorrectly

Bug #101396 reported by Andy Altepeter on 2005-03-22
6
Affects Status Importance Assigned to Milestone
Silva
Medium
Andy Altepeter

Bug Description

When using the widget renderer, if there is (for example) a complex list item
with two paragraphs, the first paragraph isn't rendered inside a <p>. This
causes the two paragraphs to run together, if the paragraph spacing is defined
by a bottom margin (or padding).

As far as I know the code bypassing the outer tag for
the first element of a list (or table cell) has been there
"since ever" (at least since 0.8)

  I admit I never thought about why it is there, but sure
it is there for some reason.

  Does anyone know why it is there? Kit, maybe?

As the XSLT renderer does not have this quirk, I am in favor
of removing this piece of code, if nobody complains.
The widget based renderer does drop the outmost tag in Silva 1.2,
too.

Andy Altepeter (aaltepet) wrote :

I think this feature was originally added so nested elements containing only
one item don't include the tag for that item, e.g.:
<li><p>this is a paragraph</p></li>

This feature omits the p:
<li>this is a paragraph</li>

Which is great, but it shouldn't omit the first element's tag if there are
multiple elements.

Martijn Faassen (faassen) wrote :

Move this off the radar for 1.2 and 1.1; surgery on the widgets with somewhat
unknown consequences is a bit too big for a bugfix.

Kit Blake (kitblake) wrote :

Let's fix this, some users still fallback to the forms editor.

Changed in silva:
assignee: nobody → aaltepet
Andy Altepeter (aaltepet) wrote :

commited fix in trunk and branches

Changed in silva:
status: Confirmed → Fix Committed
Changed in silva:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers