aborting the transaction by setting a feedback message_type should be more explicit

Reported by Jan-Wijbrand Kolman on 2004-06-24
12
Affects Status Importance Assigned to Milestone
Silva
Wishlist
Jan-Wijbrand Kolman

Bug Description

why on earth there is a *REMOVE* button.

JW wrote:

Currently, when providing user feedback where the
message_type is set to 'error', the whole ZODB transaction
is aborted.

I think there should be a seperate explicit message type for
this ("abort"?), since sometimes you do want the transaction
commited, but still provide some warning signals to the end
user.

BTW, for the Silva-1.0 branch the security declaration was
corrected (by GuidoW), but for the 0.9.3 branch it is still
wrong...

Christian Zagrodnick (zagy) wrote :

Well, in my eyes an error is an error. And if there is an
error nothing should be saved.

You still can use "warning" for notifications.

The problem with making it explicit is, that you, as a UI
developer, have to think about it. I don't think UI
developers should think about a database rollback.

Just my 2 cents.

Jan-Wijbrand Kolman (jw-infrae) wrote :

well, I still think it is somewhat weird that something high
level display-ish triggers such a low level thing implicitly.

And I, as a UI developer, got utterly confused by it :)
while developing and testing the UI.

So maybe the feedback mechanism needs an overhaul to
accomplish both goals (I do not disagree with triggering
rollbacks from the UI!).

Martijn Faassen (faassen) wrote :

I have removed Silva 0.9.3 from the list, as I'm doubtful
we'll be fixing it in that line of development.

I'm also somewhat doubtful we can fix this at this stage for
Silva 1.0, unless someone has a bright idea very quickly. :)

Jan-Wijbrand Kolman (jw-infrae) wrote :

This issue is indeed something for the future since it will need more thought
and more coding then can be done for 1.0...

I removed the 1.0 topic.

Martijn Faassen (faassen) wrote :

Review this system again for 1.1, though quite possible this won't be happening
until later.

Kit Blake (kitblake) on 2007-04-15
Changed in silva:
importance: High → Wishlist
Sylvain Viollon (thefunny) wrote :

Hopefully the whole interface have been re-factored, and this awful hack no longer exists.

Changed in silva:
milestone: none → 3.0.1
status: Confirmed → Fix Committed
Changed in silva:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers