better error handling

Bug #100144 reported by Kit Blake
10
Affects Status Importance Assigned to Milestone
Silva
Fix Released
Low
Unassigned

Bug Description

Marc Petitmermet wrote:
It would be nice if silva could catch errors; meaning that it diplays
the standard smi with the navigation on the left side and displaying
the error within the right column (BTW do these areas have a "name"?).
Or another even better implementation: the preview tab automatically
converts into an error/debug tab displaying the error instead of the
preview. Isn't the error page not also some kind of a preview?
I think it is rather confusing for a standard user when an error page
is thrown at him/her. At least we should have some comments that the
user should use the internet browsers back button to get back into the
smi (and maybe back buttom). But the above suggestion shoudn't be that
difficult to implement; when clicking on the preview silva should check
if the code throws an error and if it throws an error it shows the
error page and if not it shows the preview of the page.

Revision history for this message
Kit Blake (kitblake) wrote :

Error to catch: NotFound in editor after period of
inactivity. This is totally confusing for Authors, and we
must inform them of why it's happening.

Revision history for this message
Marc Petitmermet (petitmermet) wrote :

Yes, please. Catch it, don't show the errors. Provide some button to
reopen session. What happens to the data entered in a field which has
not been saved before the error? Some kind of routine which copies its
content to RAM and reenters the data in the newly reopened field?

Regards,
Marc

Revision history for this message
Martijn Faassen (faassen) wrote :

This issue is for discussing a better error handling in
general (better feedback pages etc).

The specific session timeout error in the editor is a rather
special case and I've opened a seperate issue for it
('better session timeout handling', issue 55).

Revision history for this message
Clemens Robbenhaar (crobbenhaar) wrote :

I vaguely remeber there has been some code written
by someone (Benno? Samuel?) which handles error messages.
 It does not look like these chnages
made it to the current CVS version.

 I did have some similar changes in my local development
version, which render an error message inside the widget
which is edit mode curently; additionally it does not
leave "mode_edit" if there is an error message after
one pushes the "save and exit" button. However this
code uses the session to store the error message between
requests and assumes the save_helper to return an error
message in case of problems; this would need more testing,
which is quite difficult as there are simply no reasons
for error messages in the current widgets of the Silva
Core; this problem only exists for custom widgets.

Revision history for this message
Martijn Faassen (faassen) wrote :

Deferring this improvement for after the release.

Revision history for this message
Martijn Faassen (faassen) wrote :

Moving this issue into 226, and resolving this one.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.