[request] notification that sikuli is running

Bug #514946 reported by Sergey Darovskih
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
SikuliX
In Progress
Wishlist
RaiMan

Bug Description

Looks like a good idea: https://answers.launchpad.net/sikuli/+question/99134. It would be nice to know that Sikuli script is running at the moment. Maybe an icon in tray or something like that.

Tags: ide scriptrun
Changed in sikuli:
importance: Undecided → Wishlist
RaiMan (raimund-hocke)
summary: - notification that sikuli is running
+ [request] notification that sikuli is running
Revision history for this message
vikramwanchoo (vikram-wanchoo) wrote :

Hi,

I have fixed this, please find the fix in the attachment.

my solution is as follows

1. SikuliTrayIcon is the class responsible for using system tray add and remove functionality.

2. Show/Remove functions of SikuliTrayIcon class are made from ScriptRunner.java runPython() function.

I am sorry for not providing diff but let me know if it acceptable.

my sikuli code version is : SikuliX_DrvBR_Rev930

Vikram Wanchoo

Revision history for this message
RaiMan (raimund-hocke) wrote :

@ Vikram
Thanks for your contribution.

First impression:
- messages should be according to Sikuli's message concept
- where should the icon image be stored in the different distributions? Shouldn't it only be available in the Windows distribution?
- The loading of the icon image should have an exception handling.
- the TrayIcon feature should be in Win32Util and used with the support of OSUtil.
- showSikuliTrayIcon is called in all cases, but removeSikuliTrayIcon only if the script execution succeeds (does not produce any exceptions). This is at least risky.
- in the show processing the tray support is checked, but not in the remove processing!

The feature as such seems to be rather simple to use (content of class SikuliTrayIcon), but the integration into the script running workflow and the build process with respect to the fact, that Sikuli supports Windows, Mac and Linux, has to be optimized.

Revision history for this message
Tsung-Hsiang Chang (vgod) wrote :

@Vikram, please make a pull request on github. This way should be easier for both of us.

RaiMan (raimund-hocke)
Changed in sikuli:
assignee: nobody → RaiMan (raimund-hocke)
status: New → In Progress
RaiMan (raimund-hocke)
tags: added: ide scriptrun
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.