[1.1.4] IDE: Toolbar buttons: crash if capture selection is drawn to another screen --- fixed 2019-02-26 build# 211

Bug #1817556 reported by RaiMan on 2019-02-25
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sikuli
Critical
RaiMan

Bug Description

observed on Windows 10 with the Offset button:

Exception in thread "AWT-EventQueue-0" java.awt.image.RasterFormatException: (x + width) is outside raster
at sun.awt.image.IntegerInterleavedRaster.createWritableChild(Unknown Source)
at java.awt.image.BufferedImage.getSubimage(Unknown Source)
at org.sikuli.util.OverlayCapturePrompt.drawSelection(OverlayCapturePrompt.java:334)
at org.sikuli.util.OverlayCapturePrompt.paint(OverlayCapturePrompt.java:384)
at javax.swing.RepaintManager$4.run(Unknown Source)
… more
[error] OverlayCapturePrompt: cropSelection: RasterFormatException

RaiMan (raimund-hocke) on 2019-02-25
Changed in sikuli:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → RaiMan (raimund-hocke)
milestone: none → 1.1.4
summary: - [1.1.4] IDE: Toolbar buttons: chrash if selection is drawn to another
+ [1.1.4] IDE: Toolbar buttons: crash if selection is drawn to another
screen
RaiMan (raimund-hocke) on 2019-02-26
summary: - [1.1.4] IDE: Toolbar buttons: crash if selection is drawn to another
- screen
+ [1.1.4] IDE: Toolbar buttons: crash if capture selection is drawn to
+ another screen
RaiMan (raimund-hocke) on 2019-02-26
summary: [1.1.4] IDE: Toolbar buttons: crash if capture selection is drawn to
- another screen
+ another screen --- fixed 2019-02-26 build# 211
RaiMan (raimund-hocke) wrote :

The implemented workflow on multi monitor:
- press a toolbar button with a capture/selection feature
- all monitors should show a read frame and the capture/selection text
- pressing the mouse on one of the monitors will
  - will still show frame and text on this monitor
  - will no longer show anything on the other monitors
- since mouse dragging cannot be restricted to the selected monitor
  - the red frame stays visible (as a reminder)
  - the selection is restricted to this monitor (though the mouse may be outside)

the last point is what should be fixed now.

Testing appreciated.

Mike (maestro+++) wrote :

Testing for Take Screenshot:

- press a toolbar button with a capture/selection feature
- all monitors should show a read frame and the capture/selection text
>>> Passed
- pressing the mouse on one of the monitors will
  - will still show frame and text on this monitor
>>> Failed: As soon as you move the cursor, the message disappears on that screen. The message stays unchanged on the other screen. If you move the cursor from the first screen (ie where the cursor was when Sikulix started executing) to the second screen, then the message on the second screen also disappears. It doesn’t matter which screen you start from or which screen the IDE was on. In both cases the actual capture looks OK. I don’t think this is a problem.
>>>Passed
- since mouse dragging cannot be restricted to the selected monitor
  - the red frame stays visible (as a reminder)
>>> Passed (actually highlighted region remains highlighted up to edge of start monitor (ie no red frame))
  - the selection is restricted to this monitor (though the mouse may be outside)

I repeated similar tests for Region, Location and Offset. They all look to behave similarly.
I did not check the actual pixel values thoroughly but they looked right.

RaiMan (raimund-hocke) wrote :

great thanks for the systematic work and docs.

I have to admit, that I wrote down the workflow from memory (due to lack of multi-monitor).

I leave this on my list to be revised again, when I can test it.

Changed in sikuli:
status: In Progress → Fix Committed
importance: Medium → Critical
Mike (maestro+++) wrote :

I'm only too pleased to be able to help. The impression I get is you maintain Sikulix almost single-handed and that must involve a lot of work. It would be better if the workload could be spread a bit more.

I am currently just a Sikulix beginner but will try and make more contributions as my knowledge progresses.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related questions